diff options
author | Kenneth Graunke <[email protected]> | 2018-12-31 09:19:07 -0800 |
---|---|---|
committer | Kenneth Graunke <[email protected]> | 2019-02-21 10:26:11 -0800 |
commit | 307f3f9924791ab0f1b830e4739bc10c28025e5a (patch) | |
tree | 183dfcb055bbd2390ff5724eb09741b5d3b5e0ac /src/gallium/drivers/iris | |
parent | 7ed1383c0ae307dac3bae45610b770b53522c34f (diff) |
iris: Leave a comment about why Broadwell images are broken
There are a variety of ways to fix this, many of which are simple, but
I could use some advice on which ones other people prefer, and so we'll
punt until after the holidays.
Diffstat (limited to 'src/gallium/drivers/iris')
-rw-r--r-- | src/gallium/drivers/iris/iris_program.c | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/src/gallium/drivers/iris/iris_program.c b/src/gallium/drivers/iris/iris_program.c index 47a4b635f99..499af26da9d 100644 --- a/src/gallium/drivers/iris/iris_program.c +++ b/src/gallium/drivers/iris/iris_program.c @@ -668,6 +668,10 @@ iris_setup_uniforms(const struct brw_compiler *compiler, nir_deref_instr *deref = nir_src_as_deref(intrin->src[0]); nir_variable *var = nir_deref_instr_get_variable(deref); + /* XXX: var->data.binding is not set properly. We need to run + * some form of gl_nir_lower_samplers_as_deref() to get it. + * This breaks tests which use more than one image. + */ if (img_idx[var->data.binding] == -1) { /* GL only allows arrays of arrays of images. */ assert(glsl_type_is_image(glsl_without_array(var->type))); |