diff options
| author | Rob Clark <[email protected]> | 2018-06-11 14:05:19 -0400 |
|---|---|---|
| committer | Rob Clark <[email protected]> | 2018-06-19 13:02:28 -0400 |
| commit | ced14f1c7a821dbb3fdb3c76b50a256c6568c714 (patch) | |
| tree | 539d78fbdee9d77501d00a7b42a2e4709648d9c2 /src/gallium/drivers/freedreno/ir3 | |
| parent | 570844059789cf497123a85ed19eac9274f11139 (diff) | |
freedreno: remove per-stateobj dirty_mask's
These never got updated in fd_context_all_dirty() so actually trying to
rely on them (in the case of fd5_emit_images()) ends up in some cases
where state is not emitted but should be. Best to just rip this out.
Signed-off-by: Rob Clark <[email protected]>
Diffstat (limited to 'src/gallium/drivers/freedreno/ir3')
| -rw-r--r-- | src/gallium/drivers/freedreno/ir3/ir3_shader.c | 5 |
1 files changed, 1 insertions, 4 deletions
diff --git a/src/gallium/drivers/freedreno/ir3/ir3_shader.c b/src/gallium/drivers/freedreno/ir3/ir3_shader.c index ff1ce4d0535..7205fb0d274 100644 --- a/src/gallium/drivers/freedreno/ir3/ir3_shader.c +++ b/src/gallium/drivers/freedreno/ir3/ir3_shader.c @@ -559,10 +559,8 @@ emit_user_consts(struct fd_context *ctx, const struct ir3_shader_variant *v, struct fd_ringbuffer *ring, struct fd_constbuf_stateobj *constbuf) { const unsigned index = 0; /* user consts are index 0 */ - /* TODO save/restore dirty_mask for binning pass instead: */ - uint32_t dirty_mask = constbuf->enabled_mask; - if (dirty_mask & (1 << index)) { + if (constbuf->enabled_mask & (1 << index)) { struct pipe_constant_buffer *cb = &constbuf->cb[index]; unsigned size = align(cb->buffer_size, 4) / 4; /* size in dwords */ @@ -587,7 +585,6 @@ emit_user_consts(struct fd_context *ctx, const struct ir3_shader_variant *v, ctx->emit_const(ring, v->type, 0, cb->buffer_offset, size, cb->user_buffer, cb->buffer); - constbuf->dirty_mask &= ~(1 << index); } } } |