diff options
| author | Roland Scheidegger <[email protected]> | 2013-02-12 16:41:56 +0100 |
|---|---|---|
| committer | Roland Scheidegger <[email protected]> | 2013-02-12 16:51:11 +0100 |
| commit | 427d36a22741890a7ce55b6b5bcd40fd4bdd2d35 (patch) | |
| tree | 7f6cc467072b0a51068edabbb12dfc25eee080da /src/gallium/docs | |
| parent | 4bfdef87e66bfb2459af570351798d7754ddfb9f (diff) | |
gallium: fix tgsi SAMPLE_L opcode to use separate source for explicit lod
It looks like using coord.w as explicit lod value is a mistake, most likely
because some dx10 docs had it specified that way. Seems this was changed though:
http://msdn.microsoft.com/en-us/library/windows/desktop/hh447229%28v=vs.85%29.aspx
- let's just hope it doesn't depend on runtime build version or something.
Not only would this need translation (so go against the stated goal these
opcodes should be close to dx10 semantics) but it would prevent usage of this
opcode with cube arrays, which is apparently possible:
http://msdn.microsoft.com/en-us/library/windows/desktop/bb509699%28v=vs.85%29.aspx
(Note not only does this show cube arrays using explicit lod, but also the
confusion with this opcode: it lists an explicit lod parameter value, but then
states last component of location is used as lod).
(For "true" hw drivers, only nv50 had code to handle it, and it appears the
code was already right for the new semantics, though fix up the seemingly
wrong c/d arguments while there.)
v2: fix comment, separate out other changes.
Reviewed-by: Jose Fonseca <[email protected]>
Diffstat (limited to 'src/gallium/docs')
| -rw-r--r-- | src/gallium/docs/source/tgsi.rst | 7 |
1 files changed, 3 insertions, 4 deletions
diff --git a/src/gallium/docs/source/tgsi.rst b/src/gallium/docs/source/tgsi.rst index 31b679621da..f13dd8fdffa 100644 --- a/src/gallium/docs/source/tgsi.rst +++ b/src/gallium/docs/source/tgsi.rst @@ -1423,11 +1423,10 @@ instructions. If in doubt double check Direct3D documentation. .. opcode:: SAMPLE_L - SAMPLE_L is identical to the SAMPLE opcode except that the LOD is provided directly as a scalar value, - representing no anisotropy. Source addresses A channel - is used as the LOD. - SAMPLE_L dst, address, sampler_view, sampler + representing no anisotropy. + SAMPLE_L dst, address, sampler_view, sampler, explicit_lod e.g. - SAMPLE_L TEMP[0], TEMP[1], SVIEW[0], SAMP[0] + SAMPLE_L TEMP[0], TEMP[1], SVIEW[0], SAMP[0], TEMP[2].x .. opcode:: GATHER4 - Gathers the four texels to be used in a bi-linear filtering operation and packs them into a single register. |