summaryrefslogtreecommitdiffstats
path: root/src/gallium/auxiliary/translate/translate_cache.c
diff options
context:
space:
mode:
authorZack Rusin <[email protected]>2014-03-03 23:09:58 -0500
committerZack Rusin <[email protected]>2014-03-04 15:56:04 -0500
commit1dd84357ec8d6894ec6bbd7040a8e8328015cd16 (patch)
treec60fe0c84816a98afa14c095267fac3b79bcc39c /src/gallium/auxiliary/translate/translate_cache.c
parent08f174daa41b89c41a87c350f407307e2ba258eb (diff)
translate: fix buffer overflows
Because in draw we always inject position at slot 0 whenever fragment shader would take the maximum number of inputs (32) it meant that we had PIPE_MAX_ATTRIBS + 1 slots to translate, which meant that we were crashing with fragment shaders that took the maximum number of attributes as inputs. The actual max number of attributes we need to translate thus is PIPE_MAX_ATTRIBS + 1. Signed-off-by: Zack Rusin <[email protected]> Reviewed-by: José Fonseca <[email protected]> Reviewed-by: Roland Scheidegger <[email protected]> Reviewed-by: Matthew McClure <[email protected]>
Diffstat (limited to 'src/gallium/auxiliary/translate/translate_cache.c')
-rw-r--r--src/gallium/auxiliary/translate/translate_cache.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/src/gallium/auxiliary/translate/translate_cache.c b/src/gallium/auxiliary/translate/translate_cache.c
index 2c1c1146072..bb8bdcb58c4 100644
--- a/src/gallium/auxiliary/translate/translate_cache.c
+++ b/src/gallium/auxiliary/translate/translate_cache.c
@@ -73,7 +73,7 @@ void translate_cache_destroy(struct translate_cache *cache)
static INLINE unsigned translate_hash_key_size(struct translate_key *key)
{
unsigned size = sizeof(struct translate_key) -
- sizeof(struct translate_element) * (PIPE_MAX_ATTRIBS - key->nr_elements);
+ sizeof(struct translate_element) * (TRANSLATE_MAX_ATTRIBS - key->nr_elements);
return size;
}