aboutsummaryrefslogtreecommitdiffstats
path: root/src/freedreno
diff options
context:
space:
mode:
authorIago Toral Quiroga <[email protected]>2020-06-25 11:54:04 +0200
committerIago Toral <[email protected]>2020-06-26 08:57:32 +0000
commit4845f184d767edebb952a0a1a0f9af769b651656 (patch)
tree52e87d98f2e7de911431df9d96e8a797f9ba64f6 /src/freedreno
parent3b1c511b099e88d1b153de784e3bf7e951a6288f (diff)
v3d/compiler: don't rewrite unused temporaries to point to NOP register
This was assuming that unused temporaries are written but never read, since the NOP register can only be used as a destination register, but we can end up here also for temporaries that are read once but never written. This was found with a graphicsfuzz test that has a switch with cases that have unreachable discards. In that test, NIR genrates code like this: decl_reg vec3 32 r19 ... r20 = mov r19.z r21 = mov r19.y r22 = mov r19.x Where r19.xyz would generate 3 temporary registers that are read but never written, so we would rewrite them to point to the NOP register as QPU instruction sources, which is not allowed and would hit an assert that expect magic reads to be from [r0,r5] only. Fixes: dEQP-VK.graphicsfuzz.unreachable-switch-case-with-discards Reviewed-by: Alejandro PiƱeiro <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5645>
Diffstat (limited to 'src/freedreno')
0 files changed, 0 insertions, 0 deletions