diff options
| author | Ilia Mirkin <[email protected]> | 2020-05-16 23:59:40 -0400 |
|---|---|---|
| committer | Marge Bot <[email protected]> | 2020-05-17 21:17:57 +0000 |
| commit | 9048adbd246c725ae80942b6b56a742ad02295dc (patch) | |
| tree | 78377988eaf22acae761153634baefabb3fd72c3 /src/freedreno | |
| parent | 8d86892ea3cd6239a9faae825bb657292a7ba848 (diff) | |
freedreno/ir3: avoid applying (sat) on bary.f
This causes failures on a3xx resulting in the non-sensical dEQP failures
on packUnorm2x16. The same test uses ldlv on a4xx+, so just disallow
(sat) on bary.f on all generations.
Signed-off-by: Ilia Mirkin <[email protected]>
Reviewed-by: Rob Clark <[email protected]>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5074>
Diffstat (limited to 'src/freedreno')
| -rw-r--r-- | src/freedreno/ir3/ir3_compiler_nir.c | 5 |
1 files changed, 5 insertions, 0 deletions
diff --git a/src/freedreno/ir3/ir3_compiler_nir.c b/src/freedreno/ir3/ir3_compiler_nir.c index 7ba65e1498e..0bfdb7adf38 100644 --- a/src/freedreno/ir3/ir3_compiler_nir.c +++ b/src/freedreno/ir3/ir3_compiler_nir.c @@ -430,9 +430,14 @@ emit_alu(struct ir3_context *ctx, nir_alu_instr *alu) * src instruction and create a mov. This is easier for cp * to eliminate. * + * NOTE: a3xx definitely seen not working with flat bary.f. Same test + * uses ldlv on a4xx+, so not definitive. Seems rare enough to apply + * everywhere. + * * TODO probably opc_cat==4 is ok too */ if (alu->src[0].src.is_ssa && + src[0]->opc != OPC_BARY_F && (list_length(&alu->src[0].src.ssa->uses) == 1) && ((opc_cat(src[0]->opc) == 2) || (opc_cat(src[0]->opc) == 3))) { src[0]->flags |= IR3_INSTR_SAT; |