aboutsummaryrefslogtreecommitdiffstats
path: root/src/freedreno/ir3/ir3_sched.c
diff options
context:
space:
mode:
authorRob Clark <[email protected]>2019-03-26 15:21:12 -0400
committerRob Clark <[email protected]>2019-03-28 14:36:24 -0400
commit26e2906382054073de7be88c5607a7bafceb1a62 (patch)
treecf729411d725bc4a588f291113c39dee0ad501b1 /src/freedreno/ir3/ir3_sched.c
parentd71ce69d9c8e54abd316be5c893a8d49a3c7ba4b (diff)
freedreno/ir3: reads/writes to unrelated arrays are not dependent
Signed-off-by: Rob Clark <[email protected]>
Diffstat (limited to 'src/freedreno/ir3/ir3_sched.c')
-rw-r--r--src/freedreno/ir3/ir3_sched.c31
1 files changed, 30 insertions, 1 deletions
diff --git a/src/freedreno/ir3/ir3_sched.c b/src/freedreno/ir3/ir3_sched.c
index 94a7fed4c95..dd9567764f7 100644
--- a/src/freedreno/ir3/ir3_sched.c
+++ b/src/freedreno/ir3/ir3_sched.c
@@ -807,6 +807,20 @@ int ir3_sched(struct ir3 *ir)
return 0;
}
+static unsigned
+get_array_id(struct ir3_instruction *instr)
+{
+ /* The expectation is that there is only a single array
+ * src or dst, ir3_cp should enforce this.
+ */
+
+ for (unsigned i = 0; i < instr->regs_count; i++)
+ if (instr->regs[i]->flags & IR3_REG_ARRAY)
+ return instr->regs[i]->array.id;
+
+ unreachable("this was unexpected");
+}
+
/* does instruction 'prior' need to be scheduled before 'instr'? */
static bool
depends_on(struct ir3_instruction *instr, struct ir3_instruction *prior)
@@ -819,7 +833,22 @@ depends_on(struct ir3_instruction *instr, struct ir3_instruction *prior)
if (((instr->barrier_class & IR3_BARRIER_EVERYTHING) && prior->barrier_class) ||
((prior->barrier_class & IR3_BARRIER_EVERYTHING) && instr->barrier_class))
return true;
- return !!(instr->barrier_class & prior->barrier_conflict);
+
+ if (instr->barrier_class & prior->barrier_conflict) {
+ if (!(instr->barrier_class & ~(IR3_BARRIER_ARRAY_R | IR3_BARRIER_ARRAY_W))) {
+ /* if only array barrier, then we can further limit false-deps
+ * by considering the array-id, ie reads/writes to different
+ * arrays do not depend on each other (no aliasing)
+ */
+ if (get_array_id(instr) != get_array_id(prior)) {
+ return false;
+ }
+ }
+
+ return true;
+ }
+
+ return false;
}
static void