summaryrefslogtreecommitdiffstats
path: root/src/egl/main/eglsurface.c
diff options
context:
space:
mode:
authorTapani Pälli <[email protected]>2016-10-20 13:51:40 +0300
committerTapani Pälli <[email protected]>2016-10-25 07:24:11 +0300
commit282b87dd03317ff39eb409b0ac2cbdc17d7e5aa3 (patch)
tree70d6e081f61c62ca8ccf436a73b2140d883590b5 /src/egl/main/eglsurface.c
parent1ef787339774bc7f1cc9c1615722f944005e070c (diff)
egl: fix type mismatch error type in _eglInitSurface
EGL spec defines EGL_BAD_MATCH for windows, pixmaps and pbuffers in case where user creates a surface but config does not support rendering to such surface type. Following quotes are from EGL 1.5 spec 3.5 "Rendering Surfaces" : for eglCreatePlatformWindowSurface, eglCreateWindowSurface: "If config does not support rendering to windows (the EGL_SURFACE_TYPE attribute does not contain EGL_WINDOW_BIT ), an EGL_BAD_MATCH error is generated." for eglCreatePbufferSurface: "If config does not support pbuffers, an EGL_BAD_MATCH error is generated." for eglCreatePlatformPixmapSurface, eglCreatePixmapSurface: "If config does not support rendering to pixmaps (the EGL_SURFACE_TYPE attribute does not contain EGL_PIXMAP_BIT ), an EGL_BAD_MATCH error is generated." Fixes following dEQP test: dEQP-EGL.functional.negative_api.create_pbuffer_surface Signed-off-by: Tapani Pälli <[email protected]> Reviewed-by: Eric Engestrom <[email protected]>
Diffstat (limited to 'src/egl/main/eglsurface.c')
-rw-r--r--src/egl/main/eglsurface.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/src/egl/main/eglsurface.c b/src/egl/main/eglsurface.c
index 231a5f01435..eb0bdfeca28 100644
--- a/src/egl/main/eglsurface.c
+++ b/src/egl/main/eglsurface.c
@@ -284,7 +284,7 @@ _eglInitSurface(_EGLSurface *surf, _EGLDisplay *dpy, EGLint type,
if ((conf->SurfaceType & type) == 0) {
/* The config can't be used to create a surface of this type */
- _eglError(EGL_BAD_CONFIG, func);
+ _eglError(EGL_BAD_MATCH, func);
return EGL_FALSE;
}