egl: Move attributes in _EGLImage to _EGLImageAttribs.

The opaque nature of EGLImage implies that extensions almost always
define their own attributes.  Move attributes in _EGLImage to
_EGLImageAttribs and add a helper function to parse attribute lists.

1 files changed, 18 insertions, 17 deletions

diff --git a/src/egl/main/eglimage.c b/src/egl/main/eglimage.c
index 5732ef35ecd..e11a1836ff6 100644
--- a/src/egl/main/eglimage.c
+++ b/src/egl/main/eglimage.c
@@ -12,27 +12,38 @@
 /**
  * Parse the list of image attributes and return the proper error code.
  */
-static EGLint
-_eglParseImageAttribList(_EGLImage *img, const EGLint *attrib_list)
+EGLint
+_eglParseImageAttribList(_EGLImageAttribs *attrs, _EGLDisplay *dpy,
+                         const EGLint *attrib_list)
 {
    EGLint i, err = EGL_SUCCESS;
 
+   (void) dpy;
+
+   memset(attrs, 0, sizeof(attrs));
+   attrs->ImagePreserved = EGL_FALSE;
+   attrs->GLTextureLevel = 0;
+   attrs->GLTextureZOffset = 0;
+
    if (!attrib_list)
-      return EGL_SUCCESS;
+      return err;
 
    for (i = 0; attrib_list[i] != EGL_NONE; i++) {
       EGLint attr = attrib_list[i++];
       EGLint val = attrib_list[i];
 
       switch (attr) {
+      /* EGL_KHR_image_base */
       case EGL_IMAGE_PRESERVED_KHR:
-         img->Preserved = val;
+         attrs->ImagePreserved = val;
          break;
+
+      /* EGL_KHR_gl_image */
       case EGL_GL_TEXTURE_LEVEL_KHR:
-         img->GLTextureLevel = val;
+         attrs->GLTextureLevel = val;
          break;
       case EGL_GL_TEXTURE_ZOFFSET_KHR:
-         img->GLTextureZOffset = val;
+         attrs->GLTextureZOffset = val;
          break;
       default:
          /* unknown attrs are ignored */
@@ -50,21 +61,11 @@ _eglParseImageAttribList(_EGLImage *img, const EGLint *attrib_list)
 
 
 EGLBoolean
-_eglInitImage(_EGLImage *img, _EGLDisplay *dpy, const EGLint *attrib_list)
+_eglInitImage(_EGLImage *img, _EGLDisplay *dpy)
 {
-   EGLint err;
-
    memset(img, 0, sizeof(_EGLImage));
    img->Resource.Display = dpy;
 
-   img->Preserved = EGL_FALSE;
-   img->GLTextureLevel = 0;
-   img->GLTextureZOffset = 0;
-
-   err = _eglParseImageAttribList(img, attrib_list);
-   if (err != EGL_SUCCESS)
-      return _eglError(err, "eglCreateImageKHR");
-
    return EGL_TRUE;
 }