diff options
author | Kenneth Graunke <[email protected]> | 2014-01-18 12:48:18 -0800 |
---|---|---|
committer | Kenneth Graunke <[email protected]> | 2014-01-22 17:18:42 -0800 |
commit | ebfe43d5ad3b00a5ee1b760392a5275bc801c47e (patch) | |
tree | 90cd0dfe8c4c71ba645ce56e66db49817c6bd685 /src/egl/main/Makefile.am | |
parent | 87e732673598ef3fd08a3432c7975b421b14c8c4 (diff) |
i965/fs: Refactor sampler message header to duplicate less code.
Previously, the code to copy g0 to the message header existed in two
places - one for the texture offset case, and one for any other case.
By treating texture_offset as a special case of header_present, we can
remove this duplication and shorten the code. Future patches which add
new header fields also won't have to add additional duplication.
This also clarifies a confusing construct. The old code contained:
} else if (inst->header_present) {
if (brw->gen >= 7) {
...explicit copy from g0 to the message header...
} else {
/* Set up an implied move from g0 to the MRF. */
}
}
This looks like it might set up an implied move on Sandybridge, which
doesn't support those. However, Sandybridge only uses a message header
for texture offsets, so it would never hit this code path. The new code
avoids this implicit knowledge by only setting up an implied move on
Gen4-5.
Signed-off-by: Kenneth Graunke <[email protected]>
Reviewed-by: Matt Turner <[email protected]>
Reviewed-by: Chris Forbes <[email protected]>
Diffstat (limited to 'src/egl/main/Makefile.am')
0 files changed, 0 insertions, 0 deletions