diff options
author | Eric Anholt <[email protected]> | 2016-09-06 19:45:51 -0700 |
---|---|---|
committer | Eric Anholt <[email protected]> | 2016-09-22 11:10:21 +0300 |
commit | 36f0f0318275f65f8744ec6f9471702e2f58e6d5 (patch) | |
tree | 1b6a4fb819a5d7a7527635edda690d9f53e5e535 /src/compiler/spirv | |
parent | 6c648cdac80233765861bfebb74a6e2725ddbf26 (diff) |
nir: Allow opt_peephole_sel to be more aggressive in flattening IFs.
VC4 was running into a major performance regression from enabling control
flow in the glmark2 conditionals test, because of short if statements
containing an ffract.
This pass seems like it was was trying to ensure that we only flattened
IFs that should be entirely a win by guaranteeing that there would be
fewer bcsels than there were MOVs otherwise. However, if the number of
ALU ops is small, we can avoid the overhead of branching (which itself
costs cycles) and still get a win, even if it means moving real
instructions out of the THEN/ELSE blocks.
For now, just turn on aggressive flattening on vc4. i965 will need some
tuning to avoid regressions. It does looks like this may be useful to
replace freedreno code.
Improves glmark2 -b conditionals:fragment-steps=5:vertex-steps=0 from 47
fps to 95 fps on vc4.
vc4 shader-db:
total instructions in shared programs: 101282 -> 99543 (-1.72%)
instructions in affected programs: 17365 -> 15626 (-10.01%)
total uniforms in shared programs: 31295 -> 31172 (-0.39%)
uniforms in affected programs: 3580 -> 3457 (-3.44%)
total estimated cycles in shared programs: 225182 -> 223746 (-0.64%)
estimated cycles in affected programs: 26085 -> 24649 (-5.51%)
v2: Update shader-db output.
Reviewed-by: Ian Romanick <[email protected]> (v1)
Diffstat (limited to 'src/compiler/spirv')
0 files changed, 0 insertions, 0 deletions