diff options
author | Iago Toral Quiroga <[email protected]> | 2019-10-29 10:12:28 +0100 |
---|---|---|
committer | Iago Toral Quiroga <[email protected]> | 2019-12-16 08:42:37 +0100 |
commit | 6c7a2b69f8df5a9c0cb8c8f3b099694bbe1b0b53 (patch) | |
tree | 3fcde4d2747cc470dfcc174df12cc4f2b585ba2e /src/compiler/shader_enums.c | |
parent | 45bc61add078b11e1809cf607e9c876329004d5d (diff) |
v3d: handle writes to gl_Layer from geometry shaders
When geometry shaders write a value to gl_Layer that doesn't correspond to
an existing layer in the target framebuffer the rendering behavior is
undefined according to the spec, however, there are CTS tests that trigger
this scenario on purpose, probably to ensure that nothing terrible happens.
For V3D, this situation is problematic because the binner uses the layer
index to select the offset to write into the tile state data, and we only
allocate tile state for MAX2(num_layers, 1), so we want to make sure we
don't produce values that would lead to out of bounds writes. The simulator
has an assert to catch this, although we haven't observed issues in actual
hardware it is probably best to play safe.
Reviewed-by: Alejandro PiƱeiro <[email protected]>
Diffstat (limited to 'src/compiler/shader_enums.c')
0 files changed, 0 insertions, 0 deletions