summaryrefslogtreecommitdiffstats
path: root/src/compiler/nir
diff options
context:
space:
mode:
authorRob Clark <[email protected]>2016-05-18 10:38:40 -0400
committerRob Clark <[email protected]>2016-05-20 11:13:50 -0400
commitfcd6b3f42be904d162b78fe75ba14c6415cdb815 (patch)
tree27591bf2ad508f19dfc4c5188ff58248e08240f3 /src/compiler/nir
parent53c48feae086bbf5b17798fc1cd98ab14a17c7a8 (diff)
nir: coverity unitialized pointer read
Not sure how coverity arrives at the conclusion that we can read comp[j] unitialized (around line 204), other than not being aware that ncomp is greater than 1 so it won't underflow in the 'if (tex->is_array)' case. Signed-off-by: Rob Clark <[email protected]> Reviewed-by: Matt Turner <[email protected]>
Diffstat (limited to 'src/compiler/nir')
-rw-r--r--src/compiler/nir/nir_lower_tex.c2
1 files changed, 2 insertions, 0 deletions
diff --git a/src/compiler/nir/nir_lower_tex.c b/src/compiler/nir/nir_lower_tex.c
index a0804754098..2086263e3fc 100644
--- a/src/compiler/nir/nir_lower_tex.c
+++ b/src/compiler/nir/nir_lower_tex.c
@@ -177,6 +177,8 @@ saturate_src(nir_builder *b, nir_tex_instr *tex, unsigned sat_mask)
/* split src into components: */
nir_ssa_def *comp[4];
+ assume(tex->coord_components >= 1);
+
for (unsigned j = 0; j < tex->coord_components; j++)
comp[j] = nir_channel(b, src, j);