summaryrefslogtreecommitdiffstats
path: root/src/compiler/glsl/lower_vector.cpp
diff options
context:
space:
mode:
authorTimothy Arceri <[email protected]>2017-08-09 13:34:02 +1000
committerTimothy Arceri <[email protected]>2017-08-11 10:43:12 +1000
commite2e2c5abd279df1b3aa99c52b81c9cb48fea35fb (patch)
tree814dcc8cf5c292ebaead53f75580c93b7f95f1ce /src/compiler/glsl/lower_vector.cpp
parent5563872dbfbf733ed56e1b367bc8944ca59b1c3e (diff)
glsl: calculate number of operands in an expression once
Extra validation is added to ir_validate to make sure this is always updated to the correct numer of operands, as passes like lower_instructions modify the instructions directly rather then generating a new one. The reduction in time is so small that it is not really measurable. However callgrind was reporting this function as being called just under 34 million times while compiling the Deus Ex shaders (just pre-linking was profiled) with 0.20% spent in this function. v2: - make num_operands a unit8_t - fix unsigned/signed mismatches Reviewed-by: Thomas Helland <[email protected]>
Diffstat (limited to 'src/compiler/glsl/lower_vector.cpp')
-rw-r--r--src/compiler/glsl/lower_vector.cpp2
1 files changed, 1 insertions, 1 deletions
diff --git a/src/compiler/glsl/lower_vector.cpp b/src/compiler/glsl/lower_vector.cpp
index a658410ae6f..72192b1b258 100644
--- a/src/compiler/glsl/lower_vector.cpp
+++ b/src/compiler/glsl/lower_vector.cpp
@@ -133,7 +133,7 @@ lower_vector_visitor::handle_rvalue(ir_rvalue **rvalue)
*/
void *const mem_ctx = expr;
- assert(expr->type->vector_elements == expr->get_num_operands());
+ assert(expr->type->vector_elements == expr->num_operands);
/* Generate a temporary with the same type as the ir_quadop_operation.
*/