summaryrefslogtreecommitdiffstats
path: root/src/amd
diff options
context:
space:
mode:
authorSamuel Pitoiset <samuel.pitoiset@gmail.com>2019-02-25 15:28:24 +0100
committerSamuel Pitoiset <samuel.pitoiset@gmail.com>2019-02-26 11:22:22 +0100
commit9256e0a09dfa94fecfef8e250755732ac35689ec (patch)
tree43069f31812628b48e517881fc11271b80978c72 /src/amd
parent1d5e5ec30a6c585fbcb3cc9e5b9c2b3e3392d940 (diff)
radv: fix out-of-bounds access when copying descriptors BO list
We shouldn't increment the buffer list pointers twice. This fixes some crashes with new CTS dEQP-VK.binding_model.descriptor_copy.*. Cc: 18.3 19.0 <mesa-stable@lists.freedesktop.org> Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com> Reviewed-by: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl>
Diffstat (limited to 'src/amd')
-rw-r--r--src/amd/vulkan/radv_descriptor_set.c2
1 files changed, 0 insertions, 2 deletions
diff --git a/src/amd/vulkan/radv_descriptor_set.c b/src/amd/vulkan/radv_descriptor_set.c
index e47ae6ad67a..e6649305961 100644
--- a/src/amd/vulkan/radv_descriptor_set.c
+++ b/src/amd/vulkan/radv_descriptor_set.c
@@ -970,8 +970,6 @@ void radv_update_descriptor_sets(
src_ptr += src_binding_layout->size / 4;
dst_ptr += dst_binding_layout->size / 4;
dst_buffer_list[j] = src_buffer_list[j];
- ++src_buffer_list;
- ++dst_buffer_list;
}
}
}