diff options
| author | Samuel Pitoiset <[email protected]> | 2018-11-15 09:58:52 +0100 |
|---|---|---|
| committer | Samuel Pitoiset <[email protected]> | 2018-11-16 17:51:15 +0100 |
| commit | d031d5c9994bd67329f2b2c7e9a4457af671b05a (patch) | |
| tree | d0a0e7e11e0ad6c95aeaa574d7e7969e0c4000d4 /src/amd | |
| parent | afd834b62e384f63b712115c1f79659b03828b0c (diff) | |
radv: enable primitive binning by default
After doing a bunch of benchmarks, primitive binning helps
some games like The Talos Principle (+5%) or Serious Sam 2017
(+3%). For other titles, either it doesn't change anything or
it hurts very few (less than 1%).
This only affects GFX9.
Signed-off-by: Samuel Pitoiset <[email protected]>
Reviewed-by: Bas Nieuwenhuizen <[email protected]>
Diffstat (limited to 'src/amd')
| -rw-r--r-- | src/amd/vulkan/radv_debug.h | 5 | ||||
| -rw-r--r-- | src/amd/vulkan/radv_device.c | 5 |
2 files changed, 3 insertions, 7 deletions
diff --git a/src/amd/vulkan/radv_debug.h b/src/amd/vulkan/radv_debug.h index 397d5679610..01712bd22ce 100644 --- a/src/amd/vulkan/radv_debug.h +++ b/src/amd/vulkan/radv_debug.h @@ -57,9 +57,8 @@ enum { RADV_PERFTEST_NO_BATCHCHAIN = 0x1, RADV_PERFTEST_SISCHED = 0x2, RADV_PERFTEST_LOCAL_BOS = 0x4, - RADV_PERFTEST_BINNING = 0x8, - RADV_PERFTEST_OUT_OF_ORDER = 0x10, - RADV_PERFTEST_DCC_MSAA = 0x20, + RADV_PERFTEST_OUT_OF_ORDER = 0x8, + RADV_PERFTEST_DCC_MSAA = 0x10, }; bool diff --git a/src/amd/vulkan/radv_device.c b/src/amd/vulkan/radv_device.c index 33ef6867fd0..70084a2b605 100644 --- a/src/amd/vulkan/radv_device.c +++ b/src/amd/vulkan/radv_device.c @@ -466,7 +466,6 @@ static const struct debug_control radv_perftest_options[] = { {"nobatchchain", RADV_PERFTEST_NO_BATCHCHAIN}, {"sisched", RADV_PERFTEST_SISCHED}, {"localbos", RADV_PERFTEST_LOCAL_BOS}, - {"binning", RADV_PERFTEST_BINNING}, {"dccmsaa", RADV_PERFTEST_DCC_MSAA}, {NULL, 0} }; @@ -1633,9 +1632,7 @@ VkResult radv_CreateDevice( } device->pbb_allowed = device->physical_device->rad_info.chip_class >= GFX9 && - ((device->instance->perftest_flags & RADV_PERFTEST_BINNING) || - device->physical_device->rad_info.family == CHIP_RAVEN || - device->physical_device->rad_info.family == CHIP_RAVEN2); + !(device->instance->debug_flags & RADV_DEBUG_NOBINNING); /* Disabled and not implemented for now. */ device->dfsm_allowed = device->pbb_allowed && |