diff options
| author | Jason Ekstrand <[email protected]> | 2019-05-06 11:45:46 -0500 |
|---|---|---|
| committer | Jason Ekstrand <[email protected]> | 2019-05-24 08:38:11 -0500 |
| commit | f2dc0f28728af63e1a79756dab06a7035fecb590 (patch) | |
| tree | 567ce89be4af1fc48d287415ab051929f0e1466e /src/amd | |
| parent | 22421ca7be608f38ce701a43e3f6b7f3132b7aab (diff) | |
nir: Drop imov/fmov in favor of one mov instruction
The difference between imov and fmov has been a constant source of
confusion in NIR for years. No one really knows why we have two or when
to use one vs. the other. The real reason is that they do different
things in the presence of source and destination modifiers. However,
without modifiers (which many back-ends don't have), they are identical.
Now that we've reworked nir_lower_to_source_mods to leave one abs/neg
instruction in place rather than replacing them with imov or fmov
instructions, we don't need two different instructions at all anymore.
Reviewed-by: Kristian H. Kristensen <[email protected]>
Reviewed-by: Alyssa Rosenzweig <[email protected]>
Reviewed-by: Vasily Khoruzhick <[email protected]>
Acked-by: Rob Clark <[email protected]>
Diffstat (limited to 'src/amd')
| -rw-r--r-- | src/amd/common/ac_nir_to_llvm.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/src/amd/common/ac_nir_to_llvm.c b/src/amd/common/ac_nir_to_llvm.c index 53c4ff7d383..265e3b636c4 100644 --- a/src/amd/common/ac_nir_to_llvm.c +++ b/src/amd/common/ac_nir_to_llvm.c @@ -572,8 +572,7 @@ static void visit_alu(struct ac_nir_context *ctx, const nir_alu_instr *instr) src[i] = get_alu_src(ctx, instr->src[i], src_components); switch (instr->op) { - case nir_op_fmov: - case nir_op_imov: + case nir_op_mov: result = src[0]; break; case nir_op_fneg: |