diff options
| author | Samuel Pitoiset <[email protected]> | 2020-04-05 09:25:18 +0200 |
|---|---|---|
| committer | Samuel Pitoiset <[email protected]> | 2020-04-09 13:34:36 +0200 |
| commit | 1d74c6565d74188efea8bdef3dd33c1e4aa21f60 (patch) | |
| tree | d0249a89c1095716fb1903a2318ff5caa5f74fcd /src/amd/vulkan/radv_shader.c | |
| parent | a3113e07b90d56a09e53b5bf2f77171d13a049d6 (diff) | |
radv: only expose shaderFloat16 for chips with double rate fp16
This disables shaderFloat16 on GFX8 because only GFX9+ supports
double rate packed math.
This improves consistency regarding other AMD Vulkan drivers and
it makes no sense to enable that feature without packed math.
This also reduces performance with Wolfeinstein Youngblood if
fp16 is forced enabled on GFX8, while it's similar on GFX9.
We might re-introduce that feature in the future with ACO support
if it ends up being faster and correct.
Signed-off-by: Samuel Pitoiset <[email protected]>
Acked-by: Daniel Schürmann <[email protected]>
Reviewed-by: Bas Nieuwenhuizen <[email protected]>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/4453>
Diffstat (limited to 'src/amd/vulkan/radv_shader.c')
| -rw-r--r-- | src/amd/vulkan/radv_shader.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/amd/vulkan/radv_shader.c b/src/amd/vulkan/radv_shader.c index bb88b368d05..b04da434660 100644 --- a/src/amd/vulkan/radv_shader.c +++ b/src/amd/vulkan/radv_shader.c @@ -350,7 +350,7 @@ radv_shader_compile_to_nir(struct radv_device *device, .device_group = true, .draw_parameters = true, .float_controls = true, - .float16 = !device->physical_device->use_aco, + .float16 = device->physical_device->rad_info.has_double_rate_fp16 && !device->physical_device->use_aco, .float64 = true, .geometry_streams = true, .image_ms_array = true, |