radv: add initial non-conformant radv vulkan driver

This squashes all the radv development up until now into
one for merging.

History can be found:
https://github.com/airlied/mesa/tree/semi-interesting

This requires llvm 3.9 and is in no way considered
a conformant vulkan implementation. It can run a number
of vulkan applications, and supports all GPUs using
the amdgpu kernel driver.

Thanks to Intel for providing anv and spirv->nir,
and Emil Velikov for reviewing build integration.

Parts of this are:
Reviewed-by: Nicolai Hähnle <[email protected]>
Acked-by: Edward O'Callaghan <[email protected]>

Authors: Bas Nieuwenhuizen and Dave Airlie
Signed-off-by: Dave Airlie <[email protected]>

1 files changed, 1782 insertions, 0 deletions

diff --git a/src/amd/vulkan/radv_device.c b/src/amd/vulkan/radv_device.c
new file mode 100644
index 00000000000..e9e00eb9673
--- /dev/null
+++ b/src/amd/vulkan/radv_device.c
@@ -0,0 +1,1782 @@
+/*
+ * Copyright © 2016 Red Hat.
+ * Copyright © 2016 Bas Nieuwenhuizen
+ *
+ * based in part on anv driver which is:
+ * Copyright © 2015 Intel Corporation
+ *
+ * Permission is hereby granted, free of charge, to any person obtaining a
+ * copy of this software and associated documentation files (the "Software"),
+ * to deal in the Software without restriction, including without limitation
+ * the rights to use, copy, modify, merge, publish, distribute, sublicense,
+ * and/or sell copies of the Software, and to permit persons to whom the
+ * Software is furnished to do so, subject to the following conditions:
+ *
+ * The above copyright notice and this permission notice (including the next
+ * paragraph) shall be included in all copies or substantial portions of the
+ * Software.
+ *
+ * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+ * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+ * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT.  IN NO EVENT SHALL
+ * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+ * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
+ * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS
+ * IN THE SOFTWARE.
+ */
+
+#include <stdbool.h>
+#include <string.h>
+#include <unistd.h>
+#include <fcntl.h>
+#include "radv_private.h"
+#include "util/strtod.h"
+
+#include <amdgpu.h>
+#include <amdgpu_drm.h>
+#include "amdgpu_id.h"
+#include "winsys/amdgpu/radv_amdgpu_winsys_public.h"
+#include "ac_llvm_util.h"
+#include "vk_format.h"
+#include "sid.h"
+#include "radv_timestamp.h"
+#include "util/debug.h"
+struct radv_dispatch_table dtable;
+
+struct radv_fence {
+	struct radeon_winsys_fence *fence;
+	bool submitted;
+	bool signalled;
+};
+
+static VkResult
+radv_physical_device_init(struct radv_physical_device *device,
+			  struct radv_instance *instance,
+			  const char *path)
+{
+	VkResult result;
+	int fd;
+
+	fd = open(path, O_RDWR | O_CLOEXEC);
+	if (fd < 0)
+		return vk_errorf(VK_ERROR_INCOMPATIBLE_DRIVER,
+				 "failed to open %s: %m", path);
+
+	device->_loader_data.loaderMagic = ICD_LOADER_MAGIC;
+	device->instance = instance;
+	assert(strlen(path) < ARRAY_SIZE(device->path));
+	strncpy(device->path, path, ARRAY_SIZE(device->path));
+
+	device->ws = radv_amdgpu_winsys_create(fd);
+	if (!device->ws) {
+		result = VK_ERROR_INCOMPATIBLE_DRIVER;
+		goto fail;
+	}
+	device->ws->query_info(device->ws, &device->rad_info);
+	result = radv_init_wsi(device);
+	if (result != VK_SUCCESS)
+		goto fail;
+
+	fprintf(stderr, "WARNING: radv is not a conformant vulkan implementation, testing use only.\n");
+	device->name = device->rad_info.name;
+	return VK_SUCCESS;
+
+fail:
+	close(fd);
+	return result;
+}
+
+static void
+radv_physical_device_finish(struct radv_physical_device *device)
+{
+	radv_finish_wsi(device);
+	device->ws->destroy(device->ws);
+}
+
+static const VkExtensionProperties global_extensions[] = {
+	{
+		.extensionName = VK_KHR_SURFACE_EXTENSION_NAME,
+		.specVersion = 25,
+	},
+#ifdef VK_USE_PLATFORM_XCB_KHR
+	{
+		.extensionName = VK_KHR_XCB_SURFACE_EXTENSION_NAME,
+		.specVersion = 5,
+	},
+#endif
+#ifdef VK_USE_PLATFORM_WAYLAND_KHR
+	{
+		.extensionName = VK_KHR_WAYLAND_SURFACE_EXTENSION_NAME,
+		.specVersion = 4,
+	},
+#endif
+};
+
+static const VkExtensionProperties device_extensions[] = {
+	{
+		.extensionName = VK_KHR_SWAPCHAIN_EXTENSION_NAME,
+		.specVersion = 67,
+	},
+};
+
+static void *
+default_alloc_func(void *pUserData, size_t size, size_t align,
+                   VkSystemAllocationScope allocationScope)
+{
+	return malloc(size);
+}
+
+static void *
+default_realloc_func(void *pUserData, void *pOriginal, size_t size,
+                     size_t align, VkSystemAllocationScope allocationScope)
+{
+	return realloc(pOriginal, size);
+}
+
+static void
+default_free_func(void *pUserData, void *pMemory)
+{
+	free(pMemory);
+}
+
+static const VkAllocationCallbacks default_alloc = {
+	.pUserData = NULL,
+	.pfnAllocation = default_alloc_func,
+	.pfnReallocation = default_realloc_func,
+	.pfnFree = default_free_func,
+};
+
+VkResult radv_CreateInstance(
+	const VkInstanceCreateInfo*                 pCreateInfo,
+	const VkAllocationCallbacks*                pAllocator,
+	VkInstance*                                 pInstance)
+{
+	struct radv_instance *instance;
+
+	assert(pCreateInfo->sType == VK_STRUCTURE_TYPE_INSTANCE_CREATE_INFO);
+
+	uint32_t client_version;
+	if (pCreateInfo->pApplicationInfo &&
+	    pCreateInfo->pApplicationInfo->apiVersion != 0) {
+		client_version = pCreateInfo->pApplicationInfo->apiVersion;
+	} else {
+		client_version = VK_MAKE_VERSION(1, 0, 0);
+	}
+
+	if (VK_MAKE_VERSION(1, 0, 0) > client_version ||
+	    client_version > VK_MAKE_VERSION(1, 0, 0xfff)) {
+		return vk_errorf(VK_ERROR_INCOMPATIBLE_DRIVER,
+				 "Client requested version %d.%d.%d",
+				 VK_VERSION_MAJOR(client_version),
+				 VK_VERSION_MINOR(client_version),
+				 VK_VERSION_PATCH(client_version));
+	}
+
+	for (uint32_t i = 0; i < pCreateInfo->enabledExtensionCount; i++) {
+		bool found = false;
+		for (uint32_t j = 0; j < ARRAY_SIZE(global_extensions); j++) {
+			if (strcmp(pCreateInfo->ppEnabledExtensionNames[i],
+				   global_extensions[j].extensionName) == 0) {
+				found = true;
+				break;
+			}
+		}
+		if (!found)
+			return vk_error(VK_ERROR_EXTENSION_NOT_PRESENT);
+	}
+
+	instance = radv_alloc2(&default_alloc, pAllocator, sizeof(*instance), 8,
+			       VK_SYSTEM_ALLOCATION_SCOPE_INSTANCE);
+	if (!instance)
+		return vk_error(VK_ERROR_OUT_OF_HOST_MEMORY);
+
+	instance->_loader_data.loaderMagic = ICD_LOADER_MAGIC;
+
+	if (pAllocator)
+		instance->alloc = *pAllocator;
+	else
+		instance->alloc = default_alloc;
+
+	instance->apiVersion = client_version;
+	instance->physicalDeviceCount = -1;
+
+	_mesa_locale_init();
+
+	VG(VALGRIND_CREATE_MEMPOOL(instance, 0, false));
+
+	*pInstance = radv_instance_to_handle(instance);
+
+	return VK_SUCCESS;
+}
+
+void radv_DestroyInstance(
+	VkInstance                                  _instance,
+	const VkAllocationCallbacks*                pAllocator)
+{
+	RADV_FROM_HANDLE(radv_instance, instance, _instance);
+
+	if (instance->physicalDeviceCount > 0) {
+		/* We support at most one physical device. */
+		assert(instance->physicalDeviceCount == 1);
+		radv_physical_device_finish(&instance->physicalDevice);
+	}
+
+	VG(VALGRIND_DESTROY_MEMPOOL(instance));
+
+	_mesa_locale_fini();
+
+	radv_free(&instance->alloc, instance);
+}
+
+VkResult radv_EnumeratePhysicalDevices(
+	VkInstance                                  _instance,
+	uint32_t*                                   pPhysicalDeviceCount,
+	VkPhysicalDevice*                           pPhysicalDevices)
+{
+	RADV_FROM_HANDLE(radv_instance, instance, _instance);
+	VkResult result;
+
+	if (instance->physicalDeviceCount < 0) {
+		char path[20];
+		for (unsigned i = 0; i < 8; i++) {
+			snprintf(path, sizeof(path), "/dev/dri/renderD%d", 128 + i);
+			result = radv_physical_device_init(&instance->physicalDevice,
+							   instance, path);
+			if (result != VK_ERROR_INCOMPATIBLE_DRIVER)
+				break;
+		}
+
+		if (result == VK_ERROR_INCOMPATIBLE_DRIVER) {
+			instance->physicalDeviceCount = 0;
+		} else if (result == VK_SUCCESS) {
+			instance->physicalDeviceCount = 1;
+		} else {
+			return result;
+		}
+	}
+
+	/* pPhysicalDeviceCount is an out parameter if pPhysicalDevices is NULL;
+	 * otherwise it's an inout parameter.
+	 *
+	 * The Vulkan spec (git aaed022) says:
+	 *
+	 *    pPhysicalDeviceCount is a pointer to an unsigned integer variable
+	 *    that is initialized with the number of devices the application is
+	 *    prepared to receive handles to. pname:pPhysicalDevices is pointer to
+	 *    an array of at least this many VkPhysicalDevice handles [...].
+	 *
+	 *    Upon success, if pPhysicalDevices is NULL, vkEnumeratePhysicalDevices
+	 *    overwrites the contents of the variable pointed to by
+	 *    pPhysicalDeviceCount with the number of physical devices in in the
+	 *    instance; otherwise, vkEnumeratePhysicalDevices overwrites
+	 *    pPhysicalDeviceCount with the number of physical handles written to
+	 *    pPhysicalDevices.
+	 */
+	if (!pPhysicalDevices) {
+		*pPhysicalDeviceCount = instance->physicalDeviceCount;
+	} else if (*pPhysicalDeviceCount >= 1) {
+		pPhysicalDevices[0] = radv_physical_device_to_handle(&instance->physicalDevice);
+		*pPhysicalDeviceCount = 1;
+	} else {
+		*pPhysicalDeviceCount = 0;
+	}
+
+	return VK_SUCCESS;
+}
+
+void radv_GetPhysicalDeviceFeatures(
+	VkPhysicalDevice                            physicalDevice,
+	VkPhysicalDeviceFeatures*                   pFeatures)
+{
+	//   RADV_FROM_HANDLE(radv_physical_device, pdevice, physicalDevice);
+
+	memset(pFeatures, 0, sizeof(*pFeatures));
+
+	*pFeatures = (VkPhysicalDeviceFeatures) {
+		.robustBufferAccess                       = true,
+		.fullDrawIndexUint32                      = true,
+		.imageCubeArray                           = true,
+		.independentBlend                         = true,
+		.geometryShader                           = false,
+		.tessellationShader                       = false,
+		.sampleRateShading                        = false,
+		.dualSrcBlend                             = true,
+		.logicOp                                  = true,
+		.multiDrawIndirect                        = true,
+		.drawIndirectFirstInstance                = true,
+		.depthClamp                               = true,
+		.depthBiasClamp                           = true,
+		.fillModeNonSolid                         = true,
+		.depthBounds                              = true,
+		.wideLines                                = true,
+		.largePoints                              = true,
+		.alphaToOne                               = true,
+		.multiViewport                            = false,
+		.samplerAnisotropy                        = false, /* FINISHME */
+		.textureCompressionETC2                   = false,
+		.textureCompressionASTC_LDR               = false,
+		.textureCompressionBC                     = true,
+		.occlusionQueryPrecise                    = true,
+		.pipelineStatisticsQuery                  = false,
+		.vertexPipelineStoresAndAtomics           = true,
+		.fragmentStoresAndAtomics                 = true,
+		.shaderTessellationAndGeometryPointSize   = true,
+		.shaderImageGatherExtended                = false,
+		.shaderStorageImageExtendedFormats        = false,
+		.shaderStorageImageMultisample            = false,
+		.shaderUniformBufferArrayDynamicIndexing  = true,
+		.shaderSampledImageArrayDynamicIndexing   = true,
+		.shaderStorageBufferArrayDynamicIndexing  = true,
+		.shaderStorageImageArrayDynamicIndexing   = true,
+		.shaderStorageImageReadWithoutFormat      = false,
+		.shaderStorageImageWriteWithoutFormat     = true,
+		.shaderClipDistance                       = true,
+		.shaderCullDistance                       = true,
+		.shaderFloat64                            = false,
+		.shaderInt64                              = false,
+		.shaderInt16                              = false,
+		.alphaToOne                               = true,
+		.variableMultisampleRate                  = false,
+		.inheritedQueries                         = false,
+	};
+}
+
+void
+radv_device_get_cache_uuid(void *uuid)
+{
+	memset(uuid, 0, VK_UUID_SIZE);
+	snprintf(uuid, VK_UUID_SIZE, "radv-%s", RADV_TIMESTAMP);
+}
+
+void radv_GetPhysicalDeviceProperties(
+	VkPhysicalDevice                            physicalDevice,
+	VkPhysicalDeviceProperties*                 pProperties)
+{
+	RADV_FROM_HANDLE(radv_physical_device, pdevice, physicalDevice);
+	VkSampleCountFlags sample_counts = 0xf;
+	VkPhysicalDeviceLimits limits = {
+		.maxImageDimension1D                      = (1 << 14),
+		.maxImageDimension2D                      = (1 << 14),
+		.maxImageDimension3D                      = (1 << 11),
+		.maxImageDimensionCube                    = (1 << 14),
+		.maxImageArrayLayers                      = (1 << 11),
+		.maxTexelBufferElements                   = 128 * 1024 * 1024,
+		.maxUniformBufferRange                    = UINT32_MAX,
+		.maxStorageBufferRange                    = UINT32_MAX,
+		.maxPushConstantsSize                     = MAX_PUSH_CONSTANTS_SIZE,
+		.maxMemoryAllocationCount                 = UINT32_MAX,
+		.maxSamplerAllocationCount                = 64 * 1024,
+		.bufferImageGranularity                   = 64, /* A cache line */
+		.sparseAddressSpaceSize                   = 0,
+		.maxBoundDescriptorSets                   = MAX_SETS,
+		.maxPerStageDescriptorSamplers            = 64,
+		.maxPerStageDescriptorUniformBuffers      = 64,
+		.maxPerStageDescriptorStorageBuffers      = 64,
+		.maxPerStageDescriptorSampledImages       = 64,
+		.maxPerStageDescriptorStorageImages       = 64,
+		.maxPerStageDescriptorInputAttachments    = 64,
+		.maxPerStageResources                     = 128,
+		.maxDescriptorSetSamplers                 = 256,
+		.maxDescriptorSetUniformBuffers           = 256,
+		.maxDescriptorSetUniformBuffersDynamic    = 256,
+		.maxDescriptorSetStorageBuffers           = 256,
+		.maxDescriptorSetStorageBuffersDynamic    = 256,
+		.maxDescriptorSetSampledImages            = 256,
+		.maxDescriptorSetStorageImages            = 256,
+		.maxDescriptorSetInputAttachments         = 256,
+		.maxVertexInputAttributes                 = 32,
+		.maxVertexInputBindings                   = 32,
+		.maxVertexInputAttributeOffset            = 2047,
+		.maxVertexInputBindingStride              = 2048,
+		.maxVertexOutputComponents                = 128,
+		.maxTessellationGenerationLevel           = 0,
+		.maxTessellationPatchSize                 = 0,
+		.maxTessellationControlPerVertexInputComponents = 0,
+		.maxTessellationControlPerVertexOutputComponents = 0,
+		.maxTessellationControlPerPatchOutputComponents = 0,
+		.maxTessellationControlTotalOutputComponents = 0,
+		.maxTessellationEvaluationInputComponents = 0,
+		.maxTessellationEvaluationOutputComponents = 0,
+		.maxGeometryShaderInvocations             = 32,
+		.maxGeometryInputComponents               = 64,
+		.maxGeometryOutputComponents              = 128,
+		.maxGeometryOutputVertices                = 256,
+		.maxGeometryTotalOutputComponents         = 1024,
+		.maxFragmentInputComponents               = 128,
+		.maxFragmentOutputAttachments             = 8,
+		.maxFragmentDualSrcAttachments            = 2,
+		.maxFragmentCombinedOutputResources       = 8,
+		.maxComputeSharedMemorySize               = 32768,
+		.maxComputeWorkGroupCount                 = { 65535, 65535, 65535 },
+		.maxComputeWorkGroupInvocations           = 16 * 1024,
+		.maxComputeWorkGroupSize = {
+			16 * 1024/*devinfo->max_cs_threads*/,
+			16 * 1024,
+			16 * 1024
+		},
+		.subPixelPrecisionBits                    = 4 /* FIXME */,
+		.subTexelPrecisionBits                    = 4 /* FIXME */,
+		.mipmapPrecisionBits                      = 4 /* FIXME */,
+		.maxDrawIndexedIndexValue                 = UINT32_MAX,
+		.maxDrawIndirectCount                     = UINT32_MAX,
+		.maxSamplerLodBias                        = 16,
+		.maxSamplerAnisotropy                     = 16,
+		.maxViewports                             = MAX_VIEWPORTS,
+		.maxViewportDimensions                    = { (1 << 14), (1 << 14) },
+		.viewportBoundsRange                      = { INT16_MIN, INT16_MAX },
+		.viewportSubPixelBits                     = 13, /* We take a float? */
+		.minMemoryMapAlignment                    = 4096, /* A page */
+		.minTexelBufferOffsetAlignment            = 1,
+		.minUniformBufferOffsetAlignment          = 4,
+		.minStorageBufferOffsetAlignment          = 4,
+		.minTexelOffset                           = -8,
+		.maxTexelOffset                           = 7,
+		.minTexelGatherOffset                     = -8,
+		.maxTexelGatherOffset                     = 7,
+		.minInterpolationOffset                   = 0, /* FIXME */
+		.maxInterpolationOffset                   = 0, /* FIXME */
+		.subPixelInterpolationOffsetBits          = 0, /* FIXME */
+		.maxFramebufferWidth                      = (1 << 14),
+		.maxFramebufferHeight                     = (1 << 14),
+		.maxFramebufferLayers                     = (1 << 10),
+		.framebufferColorSampleCounts             = sample_counts,
+		.framebufferDepthSampleCounts             = sample_counts,
+		.framebufferStencilSampleCounts           = sample_counts,
+		.framebufferNoAttachmentsSampleCounts     = sample_counts,
+		.maxColorAttachments                      = MAX_RTS,
+		.sampledImageColorSampleCounts            = sample_counts,
+		.sampledImageIntegerSampleCounts          = VK_SAMPLE_COUNT_1_BIT,
+		.sampledImageDepthSampleCounts            = sample_counts,
+		.sampledImageStencilSampleCounts          = sample_counts,
+		.storageImageSampleCounts                 = VK_SAMPLE_COUNT_1_BIT,
+		.maxSampleMaskWords                       = 1,
+		.timestampComputeAndGraphics              = false,
+		.timestampPeriod                          = 100000.0 / pdevice->rad_info.clock_crystal_freq,
+		.maxClipDistances                         = 8,
+		.maxCullDistances                         = 8,
+		.maxCombinedClipAndCullDistances          = 8,
+		.discreteQueuePriorities                  = 1,
+		.pointSizeRange                           = { 0.125, 255.875 },
+		.lineWidthRange                           = { 0.0, 7.9921875 },
+		.pointSizeGranularity                     = (1.0 / 8.0),
+		.lineWidthGranularity                     = (1.0 / 128.0),
+		.strictLines                              = false, /* FINISHME */
+		.standardSampleLocations                  = true,
+		.optimalBufferCopyOffsetAlignment         = 128,
+		.optimalBufferCopyRowPitchAlignment       = 128,
+		.nonCoherentAtomSize                      = 64,
+	};
+
+	*pProperties = (VkPhysicalDeviceProperties) {
+		.apiVersion = VK_MAKE_VERSION(1, 0, 5),
+		.driverVersion = 1,
+		.vendorID = 0x1002,
+		.deviceID = pdevice->rad_info.pci_id,
+		.deviceType = VK_PHYSICAL_DEVICE_TYPE_DISCRETE_GPU,
+		.limits = limits,
+		.sparseProperties = {0}, /* Broadwell doesn't do sparse. */
+	};
+
+	strcpy(pProperties->deviceName, pdevice->name);
+	radv_device_get_cache_uuid(pProperties->pipelineCacheUUID);
+}
+
+void radv_GetPhysicalDeviceQueueFamilyProperties(
+	VkPhysicalDevice                            physicalDevice,
+	uint32_t*                                   pCount,
+	VkQueueFamilyProperties*                    pQueueFamilyProperties)
+{
+	if (pQueueFamilyProperties == NULL) {
+		*pCount = 1;
+		return;
+	}
+	assert(*pCount >= 1);
+
+	*pQueueFamilyProperties = (VkQueueFamilyProperties) {
+		.queueFlags = VK_QUEUE_GRAPHICS_BIT |
+		VK_QUEUE_COMPUTE_BIT |
+		VK_QUEUE_TRANSFER_BIT,
+		.queueCount = 1,
+		.timestampValidBits = 64,
+		.minImageTransferGranularity = (VkExtent3D) { 1, 1, 1 },
+	};
+}
+
+void radv_GetPhysicalDeviceMemoryProperties(
+	VkPhysicalDevice                            physicalDevice,
+	VkPhysicalDeviceMemoryProperties*           pMemoryProperties)
+{
+	RADV_FROM_HANDLE(radv_physical_device, physical_device, physicalDevice);
+
+	pMemoryProperties->memoryTypeCount = 3;
+	pMemoryProperties->memoryTypes[0] = (VkMemoryType) {
+		.propertyFlags = VK_MEMORY_PROPERTY_DEVICE_LOCAL_BIT,
+		.heapIndex = 0,
+	};
+	pMemoryProperties->memoryTypes[1] = (VkMemoryType) {
+		.propertyFlags = VK_MEMORY_PROPERTY_DEVICE_LOCAL_BIT |
+		VK_MEMORY_PROPERTY_HOST_VISIBLE_BIT |
+		VK_MEMORY_PROPERTY_HOST_COHERENT_BIT,
+		.heapIndex = 0,
+	};
+	pMemoryProperties->memoryTypes[2] = (VkMemoryType) {
+		.propertyFlags = VK_MEMORY_PROPERTY_HOST_VISIBLE_BIT|
+		VK_MEMORY_PROPERTY_HOST_COHERENT_BIT |
+		VK_MEMORY_PROPERTY_HOST_CACHED_BIT,
+		.heapIndex = 1,
+	};
+
+	pMemoryProperties->memoryHeapCount = 2;
+	pMemoryProperties->memoryHeaps[0] = (VkMemoryHeap) {
+		.size = physical_device->rad_info.vram_size,
+		.flags = VK_MEMORY_HEAP_DEVICE_LOCAL_BIT,
+	};
+	pMemoryProperties->memoryHeaps[1] = (VkMemoryHeap) {
+		.size = physical_device->rad_info.gart_size,
+		.flags = 0,
+	};
+}
+
+static VkResult
+radv_queue_init(struct radv_device *device, struct radv_queue *queue)
+{
+	queue->_loader_data.loaderMagic = ICD_LOADER_MAGIC;
+	queue->device = device;
+
+	return VK_SUCCESS;
+}
+
+static void
+radv_queue_finish(struct radv_queue *queue)
+{
+}
+
+VkResult radv_CreateDevice(
+	VkPhysicalDevice                            physicalDevice,
+	const VkDeviceCreateInfo*                   pCreateInfo,
+	const VkAllocationCallbacks*                pAllocator,
+	VkDevice*                                   pDevice)
+{
+	RADV_FROM_HANDLE(radv_physical_device, physical_device, physicalDevice);
+	VkResult result;
+	struct radv_device *device;
+
+	for (uint32_t i = 0; i < pCreateInfo->enabledExtensionCount; i++) {
+		bool found = false;
+		for (uint32_t j = 0; j < ARRAY_SIZE(device_extensions); j++) {
+			if (strcmp(pCreateInfo->ppEnabledExtensionNames[i],
+				   device_extensions[j].extensionName) == 0) {
+				found = true;
+				break;
+			}
+		}
+		if (!found)
+			return vk_error(VK_ERROR_EXTENSION_NOT_PRESENT);
+	}
+
+	device = radv_alloc2(&physical_device->instance->alloc, pAllocator,
+			     sizeof(*device), 8,
+			     VK_SYSTEM_ALLOCATION_SCOPE_DEVICE);
+	if (!device)
+		return vk_error(VK_ERROR_OUT_OF_HOST_MEMORY);
+
+	device->_loader_data.loaderMagic = ICD_LOADER_MAGIC;
+	device->instance = physical_device->instance;
+
+	device->ws = physical_device->ws;
+	if (pAllocator)
+		device->alloc = *pAllocator;
+	else
+		device->alloc = physical_device->instance->alloc;
+
+	device->hw_ctx = device->ws->ctx_create(device->ws);
+	if (!device->hw_ctx) {
+		result = VK_ERROR_OUT_OF_HOST_MEMORY;
+		goto fail_free;
+	}
+
+	radv_queue_init(device, &device->queue);
+
+	result = radv_device_init_meta(device);
+	if (result != VK_SUCCESS) {
+		device->ws->ctx_destroy(device->hw_ctx);
+		goto fail_free;
+	}
+	device->allow_fast_clears = env_var_as_boolean("RADV_FAST_CLEARS", false);
+	device->allow_dcc = !env_var_as_boolean("RADV_DCC_DISABLE", false);
+
+	if (device->allow_fast_clears && device->allow_dcc)
+		radv_finishme("DCC fast clears have not been tested\n");
+
+	radv_device_init_msaa(device);
+	device->empty_cs = device->ws->cs_create(device->ws, RING_GFX);
+	radeon_emit(device->empty_cs, PKT3(PKT3_CONTEXT_CONTROL, 1, 0));
+	radeon_emit(device->empty_cs, CONTEXT_CONTROL_LOAD_ENABLE(1));
+	radeon_emit(device->empty_cs, CONTEXT_CONTROL_SHADOW_ENABLE(1));
+	device->ws->cs_finalize(device->empty_cs);
+	*pDevice = radv_device_to_handle(device);
+	return VK_SUCCESS;
+fail_free:
+	radv_free(&device->alloc, device);
+	return result;
+}
+
+void radv_DestroyDevice(
+	VkDevice                                    _device,
+	const VkAllocationCallbacks*                pAllocator)
+{
+	RADV_FROM_HANDLE(radv_device, device, _device);
+
+	device->ws->ctx_destroy(device->hw_ctx);
+	radv_queue_finish(&device->queue);
+	radv_device_finish_meta(device);
+
+	radv_free(&device->alloc, device);
+}
+
+VkResult radv_EnumerateInstanceExtensionProperties(
+	const char*                                 pLayerName,
+	uint32_t*                                   pPropertyCount,
+	VkExtensionProperties*                      pProperties)
+{
+	unsigned i;
+	if (pProperties == NULL) {
+		*pPropertyCount = ARRAY_SIZE(global_extensions);
+		return VK_SUCCESS;
+	}
+
+	for (i = 0; i < *pPropertyCount; i++)
+		memcpy(&pProperties[i], &global_extensions[i], sizeof(VkExtensionProperties));
+
+	*pPropertyCount = i;
+	if (i < ARRAY_SIZE(global_extensions))
+		return VK_INCOMPLETE;
+
+	return VK_SUCCESS;
+}
+
+VkResult radv_EnumerateDeviceExtensionProperties(
+	VkPhysicalDevice                            physicalDevice,
+	const char*                                 pLayerName,
+	uint32_t*                                   pPropertyCount,
+	VkExtensionProperties*                      pProperties)
+{
+	unsigned i;
+
+	if (pProperties == NULL) {
+		*pPropertyCount = ARRAY_SIZE(device_extensions);
+		return VK_SUCCESS;
+	}
+
+	for (i = 0; i < *pPropertyCount; i++)
+		memcpy(&pProperties[i], &device_extensions[i], sizeof(VkExtensionProperties));
+
+	*pPropertyCount = i;
+	if (i < ARRAY_SIZE(device_extensions))
+		return VK_INCOMPLETE;
+	return VK_SUCCESS;
+}
+
+VkResult radv_EnumerateInstanceLayerProperties(
+	uint32_t*                                   pPropertyCount,
+	VkLayerProperties*                          pProperties)
+{
+	if (pProperties == NULL) {
+		*pPropertyCount = 0;
+		return VK_SUCCESS;
+	}
+
+	/* None supported at this time */
+	return vk_error(VK_ERROR_LAYER_NOT_PRESENT);
+}
+
+VkResult radv_EnumerateDeviceLayerProperties(
+	VkPhysicalDevice                            physicalDevice,
+	uint32_t*                                   pPropertyCount,
+	VkLayerProperties*                          pProperties)
+{
+	if (pProperties == NULL) {
+		*pPropertyCount = 0;
+		return VK_SUCCESS;
+	}
+
+	/* None supported at this time */
+	return vk_error(VK_ERROR_LAYER_NOT_PRESENT);
+}
+
+void radv_GetDeviceQueue(
+	VkDevice                                    _device,
+	uint32_t                                    queueNodeIndex,
+	uint32_t                                    queueIndex,
+	VkQueue*                                    pQueue)
+{
+	RADV_FROM_HANDLE(radv_device, device, _device);
+
+	assert(queueIndex == 0);
+
+	*pQueue = radv_queue_to_handle(&device->queue);
+}
+
+VkResult radv_QueueSubmit(
+	VkQueue                                     _queue,
+	uint32_t                                    submitCount,
+	const VkSubmitInfo*                         pSubmits,
+	VkFence                                     _fence)
+{
+	RADV_FROM_HANDLE(radv_queue, queue, _queue);
+	RADV_FROM_HANDLE(radv_fence, fence, _fence);
+	struct radeon_winsys_fence *base_fence = fence ? fence->fence : NULL;
+	struct radeon_winsys_ctx *ctx = queue->device->hw_ctx;
+	int ret;
+
+	for (uint32_t i = 0; i < submitCount; i++) {
+		struct radeon_winsys_cs **cs_array;
+		bool can_patch = true;
+
+		if (!pSubmits[i].commandBufferCount)
+			continue;
+
+		cs_array = malloc(sizeof(struct radeon_winsys_cs *) *
+					        pSubmits[i].commandBufferCount);
+
+		for (uint32_t j = 0; j < pSubmits[i].commandBufferCount; j++) {
+			RADV_FROM_HANDLE(radv_cmd_buffer, cmd_buffer,
+					 pSubmits[i].pCommandBuffers[j]);
+			assert(cmd_buffer->level == VK_COMMAND_BUFFER_LEVEL_PRIMARY);
+
+			cs_array[j] = cmd_buffer->cs;
+			if ((cmd_buffer->usage_flags & VK_COMMAND_BUFFER_USAGE_SIMULTANEOUS_USE_BIT))
+				can_patch = false;
+		}
+		ret = queue->device->ws->cs_submit(ctx, cs_array,
+						   pSubmits[i].commandBufferCount,
+						   can_patch, base_fence);
+		if (ret)
+			radv_loge("failed to submit CS %d\n", i);
+		free(cs_array);
+	}
+
+	if (fence) {
+		if (!submitCount)
+			ret = queue->device->ws->cs_submit(ctx, &queue->device->empty_cs,
+							   1, false, base_fence);
+
+		fence->submitted = true;
+	}
+
+	return VK_SUCCESS;
+}
+
+VkResult radv_QueueWaitIdle(
+	VkQueue                                     _queue)
+{
+	RADV_FROM_HANDLE(radv_queue, queue, _queue);
+
+	queue->device->ws->ctx_wait_idle(queue->device->hw_ctx);
+	return VK_SUCCESS;
+}
+
+VkResult radv_DeviceWaitIdle(
+	VkDevice                                    _device)
+{
+	RADV_FROM_HANDLE(radv_device, device, _device);
+
+	device->ws->ctx_wait_idle(device->hw_ctx);
+	return VK_SUCCESS;
+}
+
+PFN_vkVoidFunction radv_GetInstanceProcAddr(
+	VkInstance                                  instance,
+	const char*                                 pName)
+{
+	return radv_lookup_entrypoint(pName);
+}
+
+/* The loader wants us to expose a second GetInstanceProcAddr function
+ * to work around certain LD_PRELOAD issues seen in apps.
+ */
+PUBLIC
+VKAPI_ATTR PFN_vkVoidFunction VKAPI_CALL vk_icdGetInstanceProcAddr(
+	VkInstance                                  instance,
+	const char*                                 pName);
+
+PUBLIC
+VKAPI_ATTR PFN_vkVoidFunction VKAPI_CALL vk_icdGetInstanceProcAddr(
+	VkInstance                                  instance,
+	const char*                                 pName)
+{
+	return radv_GetInstanceProcAddr(instance, pName);
+}
+
+PFN_vkVoidFunction radv_GetDeviceProcAddr(
+	VkDevice                                    device,
+	const char*                                 pName)
+{
+	return radv_lookup_entrypoint(pName);
+}
+
+VkResult radv_AllocateMemory(
+	VkDevice                                    _device,
+	const VkMemoryAllocateInfo*                 pAllocateInfo,
+	const VkAllocationCallbacks*                pAllocator,
+	VkDeviceMemory*                             pMem)
+{
+	RADV_FROM_HANDLE(radv_device, device, _device);
+	struct radv_device_memory *mem;
+	VkResult result;
+	enum radeon_bo_domain domain;
+	uint32_t flags = 0;
+	assert(pAllocateInfo->sType == VK_STRUCTURE_TYPE_MEMORY_ALLOCATE_INFO);
+
+	if (pAllocateInfo->allocationSize == 0) {
+		/* Apparently, this is allowed */
+		*pMem = VK_NULL_HANDLE;
+		return VK_SUCCESS;
+	}
+
+	mem = radv_alloc2(&device->alloc, pAllocator, sizeof(*mem), 8,
+			  VK_SYSTEM_ALLOCATION_SCOPE_OBJECT);
+	if (mem == NULL)
+		return vk_error(VK_ERROR_OUT_OF_HOST_MEMORY);
+
+	uint64_t alloc_size = align_u64(pAllocateInfo->allocationSize, 4096);
+	if (pAllocateInfo->memoryTypeIndex == 2)
+		domain = RADEON_DOMAIN_GTT;
+	else
+		domain = RADEON_DOMAIN_VRAM;
+
+	if (pAllocateInfo->memoryTypeIndex == 0)
+		flags |= RADEON_FLAG_NO_CPU_ACCESS;
+	else
+		flags |= RADEON_FLAG_CPU_ACCESS;
+	mem->bo = device->ws->buffer_create(device->ws, alloc_size, 32768,
+					       domain, flags);
+
+	if (!mem->bo) {
+		result = VK_ERROR_OUT_OF_DEVICE_MEMORY;
+		goto fail;
+	}
+	mem->type_index = pAllocateInfo->memoryTypeIndex;
+
+	*pMem = radv_device_memory_to_handle(mem);
+
+	return VK_SUCCESS;
+
+fail:
+	radv_free2(&device->alloc, pAllocator, mem);
+
+	return result;
+}
+
+void radv_FreeMemory(
+	VkDevice                                    _device,
+	VkDeviceMemory                              _mem,
+	const VkAllocationCallbacks*                pAllocator)
+{
+	RADV_FROM_HANDLE(radv_device, device, _device);
+	RADV_FROM_HANDLE(radv_device_memory, mem, _mem);
+
+	if (mem == NULL)
+		return;
+
+	device->ws->buffer_destroy(mem->bo);
+	mem->bo = NULL;
+
+	radv_free2(&device->alloc, pAllocator, mem);
+}
+
+VkResult radv_MapMemory(
+	VkDevice                                    _device,
+	VkDeviceMemory                              _memory,
+	VkDeviceSize                                offset,
+	VkDeviceSize                                size,
+	VkMemoryMapFlags                            flags,
+	void**                                      ppData)
+{
+	RADV_FROM_HANDLE(radv_device, device, _device);
+	RADV_FROM_HANDLE(radv_device_memory, mem, _memory);
+
+	if (mem == NULL) {
+		*ppData = NULL;
+		return VK_SUCCESS;
+	}
+
+	*ppData = device->ws->buffer_map(mem->bo);
+	if (*ppData) {
+		*ppData += offset;
+		return VK_SUCCESS;
+	}
+
+	return VK_ERROR_MEMORY_MAP_FAILED;
+}
+
+void radv_UnmapMemory(
+	VkDevice                                    _device,
+	VkDeviceMemory                              _memory)
+{
+	RADV_FROM_HANDLE(radv_device, device, _device);
+	RADV_FROM_HANDLE(radv_device_memory, mem, _memory);
+
+	if (mem == NULL)
+		return;
+
+	device->ws->buffer_unmap(mem->bo);
+}
+
+VkResult radv_FlushMappedMemoryRanges(
+	VkDevice                                    _device,
+	uint32_t                                    memoryRangeCount,
+	const VkMappedMemoryRange*                  pMemoryRanges)
+{
+	return VK_SUCCESS;
+}
+
+VkResult radv_InvalidateMappedMemoryRanges(
+	VkDevice                                    _device,
+	uint32_t                                    memoryRangeCount,
+	const VkMappedMemoryRange*                  pMemoryRanges)
+{
+	return VK_SUCCESS;
+}
+
+void radv_GetBufferMemoryRequirements(
+	VkDevice                                    device,
+	VkBuffer                                    _buffer,
+	VkMemoryRequirements*                       pMemoryRequirements)
+{
+	RADV_FROM_HANDLE(radv_buffer, buffer, _buffer);
+
+	/* The Vulkan spec (git aaed022) says:
+	 *
+	 *    memoryTypeBits is a bitfield and contains one bit set for every
+	 *    supported memory type for the resource. The bit `1<<i` is set if and
+	 *    only if the memory type `i` in the VkPhysicalDeviceMemoryProperties
+	 *    structure for the physical device is supported.
+	 *
+	 * We support exactly one memory type.
+	 */
+	pMemoryRequirements->memoryTypeBits = 0x7;
+
+	pMemoryRequirements->size = buffer->size;
+	pMemoryRequirements->alignment = 16;
+}
+
+void radv_GetImageMemoryRequirements(
+	VkDevice                                    device,
+	VkImage                                     _image,
+	VkMemoryRequirements*                       pMemoryRequirements)
+{
+	RADV_FROM_HANDLE(radv_image, image, _image);
+
+	/* The Vulkan spec (git aaed022) says:
+	 *
+	 *    memoryTypeBits is a bitfield and contains one bit set for every
+	 *    supported memory type for the resource. The bit `1<<i` is set if and
+	 *    only if the memory type `i` in the VkPhysicalDeviceMemoryProperties
+	 *    structure for the physical device is supported.
+	 *
+	 * We support exactly one memory type.
+	 */
+	pMemoryRequirements->memoryTypeBits = 0x7;
+
+	pMemoryRequirements->size = image->size;
+	pMemoryRequirements->alignment = image->alignment;
+}
+
+void radv_GetImageSparseMemoryRequirements(
+	VkDevice                                    device,
+	VkImage                                     image,
+	uint32_t*                                   pSparseMemoryRequirementCount,
+	VkSparseImageMemoryRequirements*            pSparseMemoryRequirements)
+{
+	stub();
+}
+
+void radv_GetDeviceMemoryCommitment(
+	VkDevice                                    device,
+	VkDeviceMemory                              memory,
+	VkDeviceSize*                               pCommittedMemoryInBytes)
+{
+	*pCommittedMemoryInBytes = 0;
+}
+
+VkResult radv_BindBufferMemory(
+	VkDevice                                    device,
+	VkBuffer                                    _buffer,
+	VkDeviceMemory                              _memory,
+	VkDeviceSize                                memoryOffset)
+{
+	RADV_FROM_HANDLE(radv_device_memory, mem, _memory);
+	RADV_FROM_HANDLE(radv_buffer, buffer, _buffer);
+
+	if (mem) {
+		buffer->bo = mem->bo;
+		buffer->offset = memoryOffset;
+	} else {
+		buffer->bo = NULL;
+		buffer->offset = 0;
+	}
+
+	return VK_SUCCESS;
+}
+
+VkResult radv_BindImageMemory(
+	VkDevice                                    device,
+	VkImage                                     _image,
+	VkDeviceMemory                              _memory,
+	VkDeviceSize                                memoryOffset)
+{
+	RADV_FROM_HANDLE(radv_device_memory, mem, _memory);
+	RADV_FROM_HANDLE(radv_image, image, _image);
+
+	if (mem) {
+		image->bo = mem->bo;
+		image->offset = memoryOffset;
+	} else {
+		image->bo = NULL;
+		image->offset = 0;
+	}
+
+	return VK_SUCCESS;
+}
+
+VkResult radv_QueueBindSparse(
+	VkQueue                                     queue,
+	uint32_t                                    bindInfoCount,
+	const VkBindSparseInfo*                     pBindInfo,
+	VkFence                                     fence)
+{
+	stub_return(VK_ERROR_INCOMPATIBLE_DRIVER);
+}
+
+VkResult radv_CreateFence(
+	VkDevice                                    _device,
+	const VkFenceCreateInfo*                    pCreateInfo,
+	const VkAllocationCallbacks*                pAllocator,
+	VkFence*                                    pFence)
+{
+	RADV_FROM_HANDLE(radv_device, device, _device);
+	struct radv_fence *fence = radv_alloc2(&device->alloc, pAllocator,
+					       sizeof(*fence), 8,
+					       VK_SYSTEM_ALLOCATION_SCOPE_OBJECT);
+
+	if (!fence)
+		return VK_ERROR_OUT_OF_HOST_MEMORY;
+
+	memset(fence, 0, sizeof(*fence));
+	fence->submitted = false;
+	fence->signalled = !!(pCreateInfo->flags & VK_FENCE_CREATE_SIGNALED_BIT);
+	fence->fence = device->ws->create_fence();
+
+
+	*pFence = radv_fence_to_handle(fence);
+
+	return VK_SUCCESS;
+}
+
+void radv_DestroyFence(
+	VkDevice                                    _device,
+	VkFence                                     _fence,
+	const VkAllocationCallbacks*                pAllocator)
+{
+	RADV_FROM_HANDLE(radv_device, device, _device);
+	RADV_FROM_HANDLE(radv_fence, fence, _fence);
+
+	if (!fence)
+		return;
+	device->ws->destroy_fence(fence->fence);
+	radv_free2(&device->alloc, pAllocator, fence);
+}
+
+static uint64_t radv_get_absolute_timeout(uint64_t timeout)
+{
+	uint64_t current_time;
+	struct timespec tv;
+
+	clock_gettime(CLOCK_MONOTONIC, &tv);
+	current_time = tv.tv_nsec + tv.tv_sec*1000000000ull;
+
+	timeout = MIN2(UINT64_MAX - current_time, timeout);
+
+	return current_time + timeout;
+}
+
+VkResult radv_WaitForFences(
+	VkDevice                                    _device,
+	uint32_t                                    fenceCount,
+	const VkFence*                              pFences,
+	VkBool32                                    waitAll,
+	uint64_t                                    timeout)
+{
+	RADV_FROM_HANDLE(radv_device, device, _device);
+	timeout = radv_get_absolute_timeout(timeout);
+
+	if (!waitAll && fenceCount > 1) {
+		fprintf(stderr, "radv: WaitForFences without waitAll not implemented yet\n");
+	}
+
+	for (uint32_t i = 0; i < fenceCount; ++i) {
+		RADV_FROM_HANDLE(radv_fence, fence, pFences[i]);
+		bool expired = false;
+
+		if (!fence->submitted)
+			return VK_TIMEOUT;
+
+		if (fence->signalled)
+			continue;
+
+		expired = device->ws->fence_wait(device->ws, fence->fence, true, timeout);
+		if (!expired)
+			return VK_TIMEOUT;
+
+		fence->signalled = true;
+	}
+
+	return VK_SUCCESS;
+}
+
+VkResult radv_ResetFences(VkDevice device,
+			  uint32_t fenceCount,
+			  const VkFence *pFences)
+{
+	for (unsigned i = 0; i < fenceCount; ++i) {
+		RADV_FROM_HANDLE(radv_fence, fence, pFences[i]);
+		fence->submitted = fence->signalled = false;
+	}
+
+	return VK_SUCCESS;
+}
+
+VkResult radv_GetFenceStatus(VkDevice _device, VkFence _fence)
+{
+	RADV_FROM_HANDLE(radv_device, device, _device);
+	RADV_FROM_HANDLE(radv_fence, fence, _fence);
+
+	if (!fence->submitted)
+		return VK_NOT_READY;
+
+	if (!device->ws->fence_wait(device->ws, fence->fence, false, 0))
+		return VK_NOT_READY;
+
+	return VK_SUCCESS;
+}
+
+
+// Queue semaphore functions
+
+VkResult radv_CreateSemaphore(
+	VkDevice                                    device,
+	const VkSemaphoreCreateInfo*                pCreateInfo,
+	const VkAllocationCallbacks*                pAllocator,
+	VkSemaphore*                                pSemaphore)
+{
+	/* The DRM execbuffer ioctl always execute in-oder, even between different
+	 * rings. As such, there's nothing to do for the user space semaphore.
+	 */
+
+	*pSemaphore = (VkSemaphore)1;
+
+	return VK_SUCCESS;
+}
+
+void radv_DestroySemaphore(
+	VkDevice                                    device,
+	VkSemaphore                                 semaphore,
+	const VkAllocationCallbacks*                pAllocator)
+{
+}
+
+VkResult radv_CreateEvent(
+	VkDevice                                    _device,
+	const VkEventCreateInfo*                    pCreateInfo,
+	const VkAllocationCallbacks*                pAllocator,
+	VkEvent*                                    pEvent)
+{
+	RADV_FROM_HANDLE(radv_device, device, _device);
+	struct radv_event *event = radv_alloc2(&device->alloc, pAllocator,
+					       sizeof(*event), 8,
+					       VK_SYSTEM_ALLOCATION_SCOPE_OBJECT);
+
+	if (!event)
+		return VK_ERROR_OUT_OF_HOST_MEMORY;
+
+	event->bo = device->ws->buffer_create(device->ws, 8, 8,
+					      RADEON_DOMAIN_GTT,
+					      RADEON_FLAG_CPU_ACCESS);
+	if (!event->bo) {
+		radv_free2(&device->alloc, pAllocator, event);
+		return VK_ERROR_OUT_OF_DEVICE_MEMORY;
+	}
+
+	event->map = (uint64_t*)device->ws->buffer_map(event->bo);
+
+	*pEvent = radv_event_to_handle(event);
+
+	return VK_SUCCESS;
+}
+
+void radv_DestroyEvent(
+	VkDevice                                    _device,
+	VkEvent                                     _event,
+	const VkAllocationCallbacks*                pAllocator)
+{
+	RADV_FROM_HANDLE(radv_device, device, _device);
+	RADV_FROM_HANDLE(radv_event, event, _event);
+
+	if (!event)
+		return;
+	device->ws->buffer_destroy(event->bo);
+	radv_free2(&device->alloc, pAllocator, event);
+}
+
+VkResult radv_GetEventStatus(
+	VkDevice                                    _device,
+	VkEvent                                     _event)
+{
+	RADV_FROM_HANDLE(radv_event, event, _event);
+
+	if (*event->map == 1)
+		return VK_EVENT_SET;
+	return VK_EVENT_RESET;
+}
+
+VkResult radv_SetEvent(
+	VkDevice                                    _device,
+	VkEvent                                     _event)
+{
+	RADV_FROM_HANDLE(radv_event, event, _event);
+	*event->map = 1;
+
+	return VK_SUCCESS;
+}
+
+VkResult radv_ResetEvent(
+    VkDevice                                    _device,
+    VkEvent                                     _event)
+{
+	RADV_FROM_HANDLE(radv_event, event, _event);
+	*event->map = 0;
+
+	return VK_SUCCESS;
+}
+
+VkResult radv_CreateBuffer(
+	VkDevice                                    _device,
+	const VkBufferCreateInfo*                   pCreateInfo,
+	const VkAllocationCallbacks*                pAllocator,
+	VkBuffer*                                   pBuffer)
+{
+	RADV_FROM_HANDLE(radv_device, device, _device);
+	struct radv_buffer *buffer;
+
+	assert(pCreateInfo->sType == VK_STRUCTURE_TYPE_BUFFER_CREATE_INFO);
+
+	buffer = radv_alloc2(&device->alloc, pAllocator, sizeof(*buffer), 8,
+			     VK_SYSTEM_ALLOCATION_SCOPE_OBJECT);
+	if (buffer == NULL)
+		return vk_error(VK_ERROR_OUT_OF_HOST_MEMORY);
+
+	buffer->size = pCreateInfo->size;
+	buffer->usage = pCreateInfo->usage;
+	buffer->bo = NULL;
+	buffer->offset = 0;
+
+	*pBuffer = radv_buffer_to_handle(buffer);
+
+	return VK_SUCCESS;
+}
+
+void radv_DestroyBuffer(
+	VkDevice                                    _device,
+	VkBuffer                                    _buffer,
+	const VkAllocationCallbacks*                pAllocator)
+{
+	RADV_FROM_HANDLE(radv_device, device, _device);
+	RADV_FROM_HANDLE(radv_buffer, buffer, _buffer);
+
+	if (!buffer)
+		return;
+
+	radv_free2(&device->alloc, pAllocator, buffer);
+}
+
+static inline unsigned
+si_tile_mode_index(const struct radv_image *image, unsigned level, bool stencil)
+{
+	if (stencil)
+		return image->surface.stencil_tiling_index[level];
+	else
+		return image->surface.tiling_index[level];
+}
+
+static void
+radv_initialise_color_surface(struct radv_device *device,
+			      struct radv_color_buffer_info *cb,
+			      struct radv_image_view *iview)
+{
+	const struct vk_format_description *desc;
+	unsigned ntype, format, swap, endian;
+	unsigned blend_clamp = 0, blend_bypass = 0;
+	unsigned pitch_tile_max, slice_tile_max, tile_mode_index;
+	uint64_t va;
+	const struct radeon_surf *surf = &iview->image->surface;
+	const struct radeon_surf_level *level_info = &surf->level[iview->base_mip];
+
+	desc = vk_format_description(iview->vk_format);
+
+	memset(cb, 0, sizeof(*cb));
+
+	va = device->ws->buffer_get_va(iview->bo) + iview->image->offset;
+	va += level_info->offset;
+	cb->cb_color_base = va >> 8;
+
+	/* CMASK variables */
+	va = device->ws->buffer_get_va(iview->bo) + iview->image->offset;
+	va += iview->image->cmask.offset;
+	cb->cb_color_cmask = va >> 8;
+	cb->cb_color_cmask_slice = iview->image->cmask.slice_tile_max;
+
+	va = device->ws->buffer_get_va(iview->bo) + iview->image->offset;
+	va += iview->image->dcc_offset;
+	cb->cb_dcc_base = va >> 8;
+
+	cb->cb_color_view = S_028C6C_SLICE_START(iview->base_layer) |
+		S_028C6C_SLICE_MAX(iview->base_layer + iview->extent.depth - 1);
+
+	cb->micro_tile_mode = iview->image->surface.micro_tile_mode;
+	pitch_tile_max = level_info->nblk_x / 8 - 1;
+	slice_tile_max = (level_info->nblk_x * level_info->nblk_y) / 64 - 1;
+	tile_mode_index = si_tile_mode_index(iview->image, iview->base_mip, false);
+
+	cb->cb_color_pitch = S_028C64_TILE_MAX(pitch_tile_max);
+	cb->cb_color_slice = S_028C68_TILE_MAX(slice_tile_max);
+
+	/* Intensity is implemented as Red, so treat it that way. */
+	cb->cb_color_attrib = S_028C74_FORCE_DST_ALPHA_1(desc->swizzle[3] == VK_SWIZZLE_1) |
+		S_028C74_TILE_MODE_INDEX(tile_mode_index);
+
+	if (iview->image->samples > 1) {
+		unsigned log_samples = util_logbase2(iview->image->samples);
+
+		cb->cb_color_attrib |= S_028C74_NUM_SAMPLES(log_samples) |
+			S_028C74_NUM_FRAGMENTS(log_samples);
+	}
+
+	if (iview->image->fmask.size) {
+		va = device->ws->buffer_get_va(iview->bo) + iview->image->offset + iview->image->fmask.offset;
+		if (device->instance->physicalDevice.rad_info.chip_class >= CIK)
+			cb->cb_color_pitch |= S_028C64_FMASK_TILE_MAX(iview->image->fmask.pitch_in_pixels / 8 - 1);
+		cb->cb_color_attrib |= S_028C74_FMASK_TILE_MODE_INDEX(iview->image->fmask.tile_mode_index);
+		cb->cb_color_fmask = va >> 8;
+		cb->cb_color_fmask_slice = S_028C88_TILE_MAX(iview->image->fmask.slice_tile_max);
+	} else {
+		/* This must be set for fast clear to work without FMASK. */
+		if (device->instance->physicalDevice.rad_info.chip_class >= CIK)
+			cb->cb_color_pitch |= S_028C64_FMASK_TILE_MAX(pitch_tile_max);
+		cb->cb_color_attrib |= S_028C74_FMASK_TILE_MODE_INDEX(tile_mode_index);
+		cb->cb_color_fmask = cb->cb_color_base;
+		cb->cb_color_fmask_slice = S_028C88_TILE_MAX(slice_tile_max);
+	}
+
+	ntype = radv_translate_color_numformat(iview->vk_format,
+					       desc,
+					       vk_format_get_first_non_void_channel(iview->vk_format));
+	format = radv_translate_colorformat(iview->vk_format);
+	if (format == V_028C70_COLOR_INVALID || ntype == ~0u)
+		radv_finishme("Illegal color\n");
+	swap = radv_translate_colorswap(iview->vk_format, FALSE);
+	endian = radv_colorformat_endian_swap(format);
+
+	/* blend clamp should be set for all NORM/SRGB types */
+	if (ntype == V_028C70_NUMBER_UNORM ||
+	    ntype == V_028C70_NUMBER_SNORM ||
+	    ntype == V_028C70_NUMBER_SRGB)
+		blend_clamp = 1;
+
+	/* set blend bypass according to docs if SINT/UINT or
+	   8/24 COLOR variants */
+	if (ntype == V_028C70_NUMBER_UINT || ntype == V_028C70_NUMBER_SINT ||
+	    format == V_028C70_COLOR_8_24 || format == V_028C70_COLOR_24_8 ||
+	    format == V_028C70_COLOR_X24_8_32_FLOAT) {
+		blend_clamp = 0;
+		blend_bypass = 1;
+	}
+#if 0
+	if ((ntype == V_028C70_NUMBER_UINT || ntype == V_028C70_NUMBER_SINT) &&
+	    (format == V_028C70_COLOR_8 ||
+	     format == V_028C70_COLOR_8_8 ||
+	     format == V_028C70_COLOR_8_8_8_8))
+		->color_is_int8 = true;
+#endif
+	cb->cb_color_info = S_028C70_FORMAT(format) |
+		S_028C70_COMP_SWAP(swap) |
+		S_028C70_BLEND_CLAMP(blend_clamp) |
+		S_028C70_BLEND_BYPASS(blend_bypass) |
+		S_028C70_SIMPLE_FLOAT(1) |
+		S_028C70_ROUND_MODE(ntype != V_028C70_NUMBER_UNORM &&
+				    ntype != V_028C70_NUMBER_SNORM &&
+				    ntype != V_028C70_NUMBER_SRGB &&
+				    format != V_028C70_COLOR_8_24 &&
+				    format != V_028C70_COLOR_24_8) |
+		S_028C70_NUMBER_TYPE(ntype) |
+		S_028C70_ENDIAN(endian);
+	if (iview->image->samples > 1)
+		if (iview->image->fmask.size)
+			cb->cb_color_info |= S_028C70_COMPRESSION(1);
+
+	if (iview->image->cmask.size && device->allow_fast_clears)
+		cb->cb_color_info |= S_028C70_FAST_CLEAR(1);
+
+	if (iview->image->surface.dcc_size && level_info->dcc_enabled)
+		cb->cb_color_info |= S_028C70_DCC_ENABLE(1);
+
+	if (device->instance->physicalDevice.rad_info.chip_class >= VI) {
+		unsigned max_uncompressed_block_size = 2;
+		if (iview->image->samples > 1) {
+			if (iview->image->surface.bpe == 1)
+				max_uncompressed_block_size = 0;
+			else if (iview->image->surface.bpe == 2)
+				max_uncompressed_block_size = 1;
+		}
+
+		cb->cb_dcc_control = S_028C78_MAX_UNCOMPRESSED_BLOCK_SIZE(max_uncompressed_block_size) |
+			S_028C78_INDEPENDENT_64B_BLOCKS(1);
+	}
+
+	/* This must be set for fast clear to work without FMASK. */
+	if (!iview->image->fmask.size &&
+	    device->instance->physicalDevice.rad_info.chip_class == SI) {
+		unsigned bankh = util_logbase2(iview->image->surface.bankh);
+		cb->cb_color_attrib |= S_028C74_FMASK_BANK_HEIGHT(bankh);
+	}
+}
+
+static void
+radv_initialise_ds_surface(struct radv_device *device,
+			   struct radv_ds_buffer_info *ds,
+			   struct radv_image_view *iview)
+{
+	unsigned level = iview->base_mip;
+	unsigned format;
+	uint64_t va, s_offs, z_offs;
+	const struct radeon_surf_level *level_info = &iview->image->surface.level[level];
+	memset(ds, 0, sizeof(*ds));
+	switch (iview->vk_format) {
+	case VK_FORMAT_D24_UNORM_S8_UINT:
+	case VK_FORMAT_X8_D24_UNORM_PACK32:
+		ds->pa_su_poly_offset_db_fmt_cntl = S_028B78_POLY_OFFSET_NEG_NUM_DB_BITS(-24);
+		ds->offset_scale = 2.0f;
+		break;
+	case VK_FORMAT_D16_UNORM:
+	case VK_FORMAT_D16_UNORM_S8_UINT:
+		ds->pa_su_poly_offset_db_fmt_cntl = S_028B78_POLY_OFFSET_NEG_NUM_DB_BITS(-16);
+		ds->offset_scale = 4.0f;
+		break;
+	case VK_FORMAT_D32_SFLOAT:
+	case VK_FORMAT_D32_SFLOAT_S8_UINT:
+		ds->pa_su_poly_offset_db_fmt_cntl = S_028B78_POLY_OFFSET_NEG_NUM_DB_BITS(-23) |
+			S_028B78_POLY_OFFSET_DB_IS_FLOAT_FMT(1);
+		ds->offset_scale = 1.0f;
+		break;
+	default:
+		break;
+	}
+
+	format = radv_translate_dbformat(iview->vk_format);
+	if (format == V_028040_Z_INVALID) {
+		fprintf(stderr, "Invalid DB format: %d, disabling DB.\n", iview->vk_format);
+	}
+
+	va = device->ws->buffer_get_va(iview->bo) + iview->image->offset;
+	s_offs = z_offs = va;
+	z_offs += iview->image->surface.level[level].offset;
+	s_offs += iview->image->surface.stencil_level[level].offset;
+
+	ds->db_depth_view = S_028008_SLICE_START(iview->base_layer) |
+		S_028008_SLICE_MAX(iview->base_layer + iview->extent.depth - 1);
+	ds->db_depth_info = S_02803C_ADDR5_SWIZZLE_MASK(1);
+	ds->db_z_info = S_028040_FORMAT(format) | S_028040_ZRANGE_PRECISION(1);
+
+	if (iview->image->samples > 1)
+		ds->db_z_info |= S_028040_NUM_SAMPLES(util_logbase2(iview->image->samples));
+
+	if (iview->image->surface.flags & RADEON_SURF_SBUFFER)
+		ds->db_stencil_info = S_028044_FORMAT(V_028044_STENCIL_8);
+	else
+		ds->db_stencil_info = S_028044_FORMAT(V_028044_STENCIL_INVALID);
+
+	if (device->instance->physicalDevice.rad_info.chip_class >= CIK) {
+		struct radeon_info *info = &device->instance->physicalDevice.rad_info;
+		unsigned tiling_index = iview->image->surface.tiling_index[level];
+		unsigned stencil_index = iview->image->surface.stencil_tiling_index[level];
+		unsigned macro_index = iview->image->surface.macro_tile_index;
+		unsigned tile_mode = info->si_tile_mode_array[tiling_index];
+		unsigned stencil_tile_mode = info->si_tile_mode_array[stencil_index];
+		unsigned macro_mode = info->cik_macrotile_mode_array[macro_index];
+
+		ds->db_depth_info |=
+			S_02803C_ARRAY_MODE(G_009910_ARRAY_MODE(tile_mode)) |
+			S_02803C_PIPE_CONFIG(G_009910_PIPE_CONFIG(tile_mode)) |
+			S_02803C_BANK_WIDTH(G_009990_BANK_WIDTH(macro_mode)) |
+			S_02803C_BANK_HEIGHT(G_009990_BANK_HEIGHT(macro_mode)) |
+			S_02803C_MACRO_TILE_ASPECT(G_009990_MACRO_TILE_ASPECT(macro_mode)) |
+			S_02803C_NUM_BANKS(G_009990_NUM_BANKS(macro_mode));
+		ds->db_z_info |= S_028040_TILE_SPLIT(G_009910_TILE_SPLIT(tile_mode));
+		ds->db_stencil_info |= S_028044_TILE_SPLIT(G_009910_TILE_SPLIT(stencil_tile_mode));
+	} else {
+		unsigned tile_mode_index = si_tile_mode_index(iview->image, level, false);
+		ds->db_z_info |= S_028040_TILE_MODE_INDEX(tile_mode_index);
+		tile_mode_index = si_tile_mode_index(iview->image, level, true);
+		ds->db_stencil_info |= S_028044_TILE_MODE_INDEX(tile_mode_index);
+	}
+
+	if (iview->image->htile.size && !level) {
+		ds->db_z_info |= S_028040_TILE_SURFACE_ENABLE(1) |
+			S_028040_ALLOW_EXPCLEAR(1);
+
+		if (iview->image->surface.flags & RADEON_SURF_SBUFFER) {
+			/* Workaround: For a not yet understood reason, the
+			 * combination of MSAA, fast stencil clear and stencil
+			 * decompress messes with subsequent stencil buffer
+			 * uses. Problem was reproduced on Verde, Bonaire,
+			 * Tonga, and Carrizo.
+			 *
+			 * Disabling EXPCLEAR works around the problem.
+			 *
+			 * Check piglit's arb_texture_multisample-stencil-clear
+			 * test if you want to try changing this.
+			 */
+			if (iview->image->samples <= 1)
+				ds->db_stencil_info |= S_028044_ALLOW_EXPCLEAR(1);
+		} else
+			/* Use all of the htile_buffer for depth if there's no stencil. */
+			ds->db_stencil_info |= S_028044_TILE_STENCIL_DISABLE(1);
+
+		va = device->ws->buffer_get_va(iview->bo) + iview->image->offset +
+		     iview->image->htile.offset;
+		ds->db_htile_data_base = va >> 8;
+		ds->db_htile_surface = S_028ABC_FULL_CACHE(1);
+	} else {
+		ds->db_htile_data_base = 0;
+		ds->db_htile_surface = 0;
+	}
+
+	ds->db_z_read_base = ds->db_z_write_base = z_offs >> 8;
+	ds->db_stencil_read_base = ds->db_stencil_write_base = s_offs >> 8;
+
+	ds->db_depth_size = S_028058_PITCH_TILE_MAX((level_info->nblk_x / 8) - 1) |
+		S_028058_HEIGHT_TILE_MAX((level_info->nblk_y / 8) - 1);
+	ds->db_depth_slice = S_02805C_SLICE_TILE_MAX((level_info->nblk_x * level_info->nblk_y) / 64 - 1);
+}
+
+VkResult radv_CreateFramebuffer(
+	VkDevice                                    _device,
+	const VkFramebufferCreateInfo*              pCreateInfo,
+	const VkAllocationCallbacks*                pAllocator,
+	VkFramebuffer*                              pFramebuffer)
+{
+	RADV_FROM_HANDLE(radv_device, device, _device);
+	struct radv_framebuffer *framebuffer;
+
+	assert(pCreateInfo->sType == VK_STRUCTURE_TYPE_FRAMEBUFFER_CREATE_INFO);
+
+	size_t size = sizeof(*framebuffer) +
+		sizeof(struct radv_attachment_info) * pCreateInfo->attachmentCount;
+	framebuffer = radv_alloc2(&device->alloc, pAllocator, size, 8,
+				  VK_SYSTEM_ALLOCATION_SCOPE_OBJECT);
+	if (framebuffer == NULL)
+		return vk_error(VK_ERROR_OUT_OF_HOST_MEMORY);
+
+	framebuffer->attachment_count = pCreateInfo->attachmentCount;
+	for (uint32_t i = 0; i < pCreateInfo->attachmentCount; i++) {
+		VkImageView _iview = pCreateInfo->pAttachments[i];
+		struct radv_image_view *iview = radv_image_view_from_handle(_iview);
+		framebuffer->attachments[i].attachment = iview;
+		if (iview->aspect_mask & VK_IMAGE_ASPECT_COLOR_BIT) {
+			radv_initialise_color_surface(device, &framebuffer->attachments[i].cb, iview);
+		} else if (iview->aspect_mask & (VK_IMAGE_ASPECT_DEPTH_BIT | VK_IMAGE_ASPECT_STENCIL_BIT)) {
+			radv_initialise_ds_surface(device, &framebuffer->attachments[i].ds, iview);
+		}
+	}
+
+	framebuffer->width = pCreateInfo->width;
+	framebuffer->height = pCreateInfo->height;
+	framebuffer->layers = pCreateInfo->layers;
+
+	*pFramebuffer = radv_framebuffer_to_handle(framebuffer);
+	return VK_SUCCESS;
+}
+
+void radv_DestroyFramebuffer(
+	VkDevice                                    _device,
+	VkFramebuffer                               _fb,
+	const VkAllocationCallbacks*                pAllocator)
+{
+	RADV_FROM_HANDLE(radv_device, device, _device);
+	RADV_FROM_HANDLE(radv_framebuffer, fb, _fb);
+
+	if (!fb)
+		return;
+	radv_free2(&device->alloc, pAllocator, fb);
+}
+
+static unsigned radv_tex_wrap(VkSamplerAddressMode address_mode)
+{
+	switch (address_mode) {
+	case VK_SAMPLER_ADDRESS_MODE_REPEAT:
+		return V_008F30_SQ_TEX_WRAP;
+	case VK_SAMPLER_ADDRESS_MODE_MIRRORED_REPEAT:
+		return V_008F30_SQ_TEX_MIRROR;
+	case VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_EDGE:
+		return V_008F30_SQ_TEX_CLAMP_LAST_TEXEL;
+	case VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_BORDER:
+		return V_008F30_SQ_TEX_CLAMP_BORDER;
+	case VK_SAMPLER_ADDRESS_MODE_MIRROR_CLAMP_TO_EDGE:
+		return V_008F30_SQ_TEX_MIRROR_ONCE_LAST_TEXEL;
+	default:
+		unreachable("illegal tex wrap mode");
+		break;
+	}
+}
+
+static unsigned
+radv_tex_compare(VkCompareOp op)
+{
+	switch (op) {
+	case VK_COMPARE_OP_NEVER:
+		return V_008F30_SQ_TEX_DEPTH_COMPARE_NEVER;
+	case VK_COMPARE_OP_LESS:
+		return V_008F30_SQ_TEX_DEPTH_COMPARE_LESS;
+	case VK_COMPARE_OP_EQUAL:
+		return V_008F30_SQ_TEX_DEPTH_COMPARE_EQUAL;
+	case VK_COMPARE_OP_LESS_OR_EQUAL:
+		return V_008F30_SQ_TEX_DEPTH_COMPARE_LESSEQUAL;
+	case VK_COMPARE_OP_GREATER:
+		return V_008F30_SQ_TEX_DEPTH_COMPARE_GREATER;
+	case VK_COMPARE_OP_NOT_EQUAL:
+		return V_008F30_SQ_TEX_DEPTH_COMPARE_NOTEQUAL;
+	case VK_COMPARE_OP_GREATER_OR_EQUAL:
+		return V_008F30_SQ_TEX_DEPTH_COMPARE_GREATEREQUAL;
+	case VK_COMPARE_OP_ALWAYS:
+		return V_008F30_SQ_TEX_DEPTH_COMPARE_ALWAYS;
+	default:
+		unreachable("illegal compare mode");
+		break;
+	}
+}
+
+static unsigned
+radv_tex_filter(VkFilter filter, unsigned max_ansio)
+{
+	switch (filter) {
+	case VK_FILTER_NEAREST:
+		return (max_ansio > 1 ? V_008F38_SQ_TEX_XY_FILTER_ANISO_POINT :
+			V_008F38_SQ_TEX_XY_FILTER_POINT);
+	case VK_FILTER_LINEAR:
+		return (max_ansio > 1 ? V_008F38_SQ_TEX_XY_FILTER_ANISO_BILINEAR :
+			V_008F38_SQ_TEX_XY_FILTER_BILINEAR);
+	case VK_FILTER_CUBIC_IMG:
+	default:
+		fprintf(stderr, "illegal texture filter");
+		return 0;
+	}
+}
+
+static unsigned
+radv_tex_mipfilter(VkSamplerMipmapMode mode)
+{
+	switch (mode) {
+	case VK_SAMPLER_MIPMAP_MODE_NEAREST:
+		return V_008F38_SQ_TEX_Z_FILTER_POINT;
+	case VK_SAMPLER_MIPMAP_MODE_LINEAR:
+		return V_008F38_SQ_TEX_Z_FILTER_LINEAR;
+	default:
+		return V_008F38_SQ_TEX_Z_FILTER_NONE;
+	}
+}
+
+static unsigned
+radv_tex_bordercolor(VkBorderColor bcolor)
+{
+	switch (bcolor) {
+	case VK_BORDER_COLOR_FLOAT_TRANSPARENT_BLACK:
+	case VK_BORDER_COLOR_INT_TRANSPARENT_BLACK:
+		return V_008F3C_SQ_TEX_BORDER_COLOR_TRANS_BLACK;
+	case VK_BORDER_COLOR_FLOAT_OPAQUE_BLACK:
+	case VK_BORDER_COLOR_INT_OPAQUE_BLACK:
+		return V_008F3C_SQ_TEX_BORDER_COLOR_OPAQUE_BLACK;
+	case VK_BORDER_COLOR_FLOAT_OPAQUE_WHITE:
+	case VK_BORDER_COLOR_INT_OPAQUE_WHITE:
+		return V_008F3C_SQ_TEX_BORDER_COLOR_OPAQUE_WHITE;
+	default:
+		break;
+	}
+	return 0;
+}
+
+static void
+radv_init_sampler(struct radv_device *device,
+		  struct radv_sampler *sampler,
+		  const VkSamplerCreateInfo *pCreateInfo)
+{
+	uint32_t max_aniso = 0;
+	uint32_t max_aniso_ratio = 0;//TODO
+	bool is_vi;
+	is_vi = (device->instance->physicalDevice.rad_info.chip_class >= VI);
+
+	sampler->state[0] = (S_008F30_CLAMP_X(radv_tex_wrap(pCreateInfo->addressModeU)) |
+			     S_008F30_CLAMP_Y(radv_tex_wrap(pCreateInfo->addressModeV)) |
+			     S_008F30_CLAMP_Z(radv_tex_wrap(pCreateInfo->addressModeW)) |
+			     S_008F30_MAX_ANISO_RATIO(max_aniso_ratio) |
+			     S_008F30_DEPTH_COMPARE_FUNC(radv_tex_compare(pCreateInfo->compareOp)) |
+			     S_008F30_FORCE_UNNORMALIZED(pCreateInfo->unnormalizedCoordinates ? 1 : 0) |
+			     S_008F30_DISABLE_CUBE_WRAP(0) |
+			     S_008F30_COMPAT_MODE(is_vi));
+	sampler->state[1] = (S_008F34_MIN_LOD(S_FIXED(CLAMP(pCreateInfo->minLod, 0, 15), 8)) |
+			     S_008F34_MAX_LOD(S_FIXED(CLAMP(pCreateInfo->maxLod, 0, 15), 8)));
+	sampler->state[2] = (S_008F38_LOD_BIAS(S_FIXED(CLAMP(pCreateInfo->mipLodBias, -16, 16), 8)) |
+			     S_008F38_XY_MAG_FILTER(radv_tex_filter(pCreateInfo->magFilter, max_aniso)) |
+			     S_008F38_XY_MIN_FILTER(radv_tex_filter(pCreateInfo->minFilter, max_aniso)) |
+			     S_008F38_MIP_FILTER(radv_tex_mipfilter(pCreateInfo->mipmapMode)) |
+			     S_008F38_MIP_POINT_PRECLAMP(1) |
+			     S_008F38_DISABLE_LSB_CEIL(1) |
+			     S_008F38_FILTER_PREC_FIX(1) |
+			     S_008F38_ANISO_OVERRIDE(is_vi));
+	sampler->state[3] = (S_008F3C_BORDER_COLOR_PTR(0) |
+			     S_008F3C_BORDER_COLOR_TYPE(radv_tex_bordercolor(pCreateInfo->borderColor)));
+}
+
+VkResult radv_CreateSampler(
+	VkDevice                                    _device,
+	const VkSamplerCreateInfo*                  pCreateInfo,
+	const VkAllocationCallbacks*                pAllocator,
+	VkSampler*                                  pSampler)
+{
+	RADV_FROM_HANDLE(radv_device, device, _device);
+	struct radv_sampler *sampler;
+
+	assert(pCreateInfo->sType == VK_STRUCTURE_TYPE_SAMPLER_CREATE_INFO);
+
+	sampler = radv_alloc2(&device->alloc, pAllocator, sizeof(*sampler), 8,
+			      VK_SYSTEM_ALLOCATION_SCOPE_OBJECT);
+	if (!sampler)
+		return vk_error(VK_ERROR_OUT_OF_HOST_MEMORY);
+
+	radv_init_sampler(device, sampler, pCreateInfo);
+	*pSampler = radv_sampler_to_handle(sampler);
+
+	return VK_SUCCESS;
+}
+
+void radv_DestroySampler(
+	VkDevice                                    _device,
+	VkSampler                                   _sampler,
+	const VkAllocationCallbacks*                pAllocator)
+{
+	RADV_FROM_HANDLE(radv_device, device, _device);
+	RADV_FROM_HANDLE(radv_sampler, sampler, _sampler);
+
+	if (!sampler)
+		return;
+	radv_free2(&device->alloc, pAllocator, sampler);
+}