summaryrefslogtreecommitdiffstats
path: root/src/Makefile.am
diff options
context:
space:
mode:
authorKenneth Graunke <[email protected]>2014-02-28 23:15:49 -0800
committerKenneth Graunke <[email protected]>2014-03-02 13:35:03 -0800
commit3f37dd913f3461fb197e878739a269e639852667 (patch)
tree20dd1bc68dbf37d3f45666cbff893d6e1e292156 /src/Makefile.am
parentecb71cfa66f4257661579a0afa5f9c56c7dbfce2 (diff)
glsl: Fix broken LRP algebraic optimization.
opt_algebraic was translating lrp(x, 0, a) into add(x, -mul(x, a)). Unfortunately, this references "x" twice, which is invalid in the IR, leading to assertion failures in the validator. Normally, cloning IR solves this. However, "x" could actually be an arbitrary expression tree, so copying it could result in huge piles of wasted computation. This is why we avoid reusing subexpressions. Instead, transform it into mul(x, add(1.0, -a)), which is equivalent but doesn't need two references to "x". Fixes a regression since d5fa8a95621169, which isn't in any stable branches. Fixes 18 shaders in shader-db (bastion and yofrankie). Signed-off-by: Kenneth Graunke <[email protected]> Reviewed-by: Ian Romanick <[email protected]> Reviewed-by: Matt Turner <[email protected]>
Diffstat (limited to 'src/Makefile.am')
0 files changed, 0 insertions, 0 deletions