diff options
author | Erik Faye-Lund <[email protected]> | 2018-11-22 11:10:50 +0100 |
---|---|---|
committer | Erik Faye-Lund <[email protected]> | 2018-11-26 12:29:54 +0100 |
commit | c120dbfe4d18240315ecec9b43a61aeb9ab239ac (patch) | |
tree | 8c1bc3097c3208da2757f5cd4fbc305e043e91f3 /m4 | |
parent | 38af69adfaf47019926bfe3a8cf352752068d389 (diff) |
mesa/main: fix incorrect depth-error
If glGetTexImage or glGetnTexImage is called with a level that doesn't
exist, we get an error message on this form:
Mesa: User error: GL_INVALID_VALUE in glGetTexImage(depth = 0)
This is clearly nonsensical, because these APIs don't even have a
depth-parameter. The reason is that get_texture_image_dims() return
all-zero dimensions for non-existent texture-images, and we go on to
validate these dimensions as if they were user-input, because
glGetTextureSubImage requires checking.
So let's split this logic in two, so glGetTextureSubImage can have
stricter input-validation. All arguments that are no longer validated
are generated internally by mesa, so there's no use in validating them.
Fixes: 42891dbaa12 "gettextsubimage: verify zoffset and depth are correct"
Signed-off-by: Erik Faye-Lund <[email protected]>
Reviewed-by: Juan A. Suarez <[email protected]>
Diffstat (limited to 'm4')
0 files changed, 0 insertions, 0 deletions