diff options
author | Alejandro Piñeiro <[email protected]> | 2018-08-08 13:41:58 +0200 |
---|---|---|
committer | Alejandro Piñeiro <[email protected]> | 2018-08-13 16:28:27 +0200 |
commit | fe2de39fb2ef4caca2afd483c375bd0aa31fbb6d (patch) | |
tree | e707b16e89a042bb3ebdc10b465be4a9a5c32d01 /install-gallium-links.mk | |
parent | 5332d7582dc82fcf25cd48e9096dc98ef998453e (diff) |
nir/linker: take into account hidden uniforms
So they are not exposed through the introspection API.
It is worth to note that the number of hidden uniforms of GLSL linking
vs SPIR-V linking would be somewhat different due the differen order
of the nir lowerings/optimizations.
For example: gl_FbWposYTransform. This is introduced as part of
nir_lower_wpos_ytransform. On GLSL that is executed after the IR-based
linking. So that means that on GLSL the UniformStorage will not
include this uniform. With the SPIR-V linking, that uniform is already
present, but marked as hidden. So it will be included on the
UniformStorage, but as hidden.
One alternative would create a special how_declared for that case, but
seemed an overkill. Using hidden should be ok as far as it is used
properly.
Reviewed-by: Timothy Arceri <[email protected]>
Diffstat (limited to 'install-gallium-links.mk')
0 files changed, 0 insertions, 0 deletions