summaryrefslogtreecommitdiffstats
path: root/docs
diff options
context:
space:
mode:
authorDylan Baker <[email protected]>2019-09-25 11:10:15 -0700
committerDylan Baker <[email protected]>2019-10-03 17:45:51 +0000
commit9af6c38deff0f91c6c2a20d61a07a388594a39ac (patch)
treeb24afd571528705c7be746d1cf562c8c29f37b32 /docs
parent0d606211014ddedc0eafedda53763651060b2279 (diff)
docs: Add use of Closes: tag for closing gitlab issues
This replaces to old Bugzilla: tag, which no longer makes sense because we don't use bugzilla anymore. Reviewed-by: Eric Anholt <[email protected]> (v1) Reviewed-by: Eric Engestrom <[email protected]>
Diffstat (limited to 'docs')
-rw-r--r--docs/submittingpatches.html10
1 files changed, 7 insertions, 3 deletions
diff --git a/docs/submittingpatches.html b/docs/submittingpatches.html
index 786af10459e..96aed289311 100644
--- a/docs/submittingpatches.html
+++ b/docs/submittingpatches.html
@@ -75,11 +75,15 @@ if needed. For example:
platform.
</pre>
<li>A "Signed-off-by:" line is not required, but not discouraged either.
-<li>If a patch addresses a bugzilla issue, that should be noted in the
-patch comment. For example:
+<li>If a patch addresses an issue in gitlab, use the Closes: tag
+For example:
<pre>
- Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=89689
+ Closes: https://gitlab.freedesktop.org/mesa/mesa/issues/1
</pre>
+<p>Prefer the full url to just <pre>Closes: #1</pre>, since the url makes it
+easier to get to the bug page from <pre>git log</pre></p>
+<b>Do not use the Fixes: tag for this!</b> Mesa already uses Fixes for something else.
+
<li>If a patch addresses a issue introduced with earlier commit, that should be
noted in the patch comment. For example:
<pre>