summaryrefslogtreecommitdiffstats
path: root/docs
diff options
context:
space:
mode:
authorKenneth Graunke <[email protected]>2015-03-05 23:18:36 -0800
committerKenneth Graunke <[email protected]>2015-03-08 20:03:36 -0700
commit9f1e250e77ebd9255bbd9a83bd68c9e4068c2aab (patch)
tree3b55c5e9297889aff4a9467976e990de75e74413 /docs
parenta84f66a9b6cf46bb19ca71faca5b1d6d81209caf (diff)
glsl: Mark array access when copying to a temporary for the ?: operator.
Piglit's spec/glsl-1.20/compiler/structure-and-array-operations/ array-selection.vert test contains the following code: gl_Position = (pick_from_a_or_b ? a : b)[i]; where "a" and "b" are uniform vec4[2] variables. ast_to_hir creates a temporary vec4[2] variable, conditional_tmp, and generates an if-block to copy one or the other: (declare (temporary) (array vec4 2) conditional_tmp) (if (var_ref pick_from_a_or_b) ((assign () (var_ref conditional_tmp) (var_ref a))) ((assign () (var_ref conditional_tmp) (var_ref b)))) However, we failed to update max_array_access for "a" and "b", so it remained 0 - here, the whole array is being accessed. At link time, update_array_sizes() used this bogus information to change the types of "a" and "b" to vec4[1]. We then had assignments from a vec4[1] to a vec4[2], which is highly illegal. This tripped assertions in nir_split_var_copies with scalar VS. Signed-off-by: Kenneth Graunke <[email protected]> Reviewed-by: Jason Ekstrand <[email protected]> Cc: [email protected]
Diffstat (limited to 'docs')
0 files changed, 0 insertions, 0 deletions