diff options
author | Eric Anholt <[email protected]> | 2017-10-17 15:41:25 -0700 |
---|---|---|
committer | Eric Anholt <[email protected]> | 2017-10-24 10:51:18 -0700 |
commit | e91c3540fc620b39a16d5bce9fd75aa0ddd7ed7e (patch) | |
tree | 431871a42483136c8007be921384b5be7487f385 /docs/utilities.html | |
parent | eed9685dd6619ec7598e8c3fd81117d36010510d (diff) |
i965: Fix memmem compiler warnings.
gcc is throwing this warning in my meson build:
../src/intel/compiler/brw_eu_validate.c:50:11: warning
argument 1 null where non-null expected [-Wnonnull]
return memmem(haystack.str, haystack.len,
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
needle.str, needle.len) != NULL;
~~~~~~~~~~~~~~~~~~~~~~~
The first check for CONTAINS has a NULL error_msg.str and 0 len. The
glibc implementation will exit without looking at any haystack bytes if
haystack.len < needle.len, so this was safe, but silence the warning
anyway by guarding against implementation variablility.
Fixes: 122ef3799d56 ("i965: Only insert error message if not already present")
Reviewed-by: Matt Turner <[email protected]>
Diffstat (limited to 'docs/utilities.html')
0 files changed, 0 insertions, 0 deletions