diff options
| author | Eric Anholt <[email protected]> | 2018-12-12 11:11:07 -0800 |
|---|---|---|
| committer | Eric Anholt <[email protected]> | 2018-12-19 12:49:17 -0800 |
| commit | 90818558f0e8e50cd20f637775f072b5511edfd0 (patch) | |
| tree | 3d55bfb2836fe6d79c561a85dc9ad44a9038ca2d /docs/submittingpatches.html | |
| parent | 463df0ffe28eb300b1bd7bc63ede46e9405d529d (diff) | |
docs: Add an encouraging note about providing reviews and acks.
Across several projects I've seen new contributors say "I wasn't sure if I
should provide a review tag since I'm not really an expert in this area."
Everyone I know already applies some implicit weighting to reviews from
different people, so encourage participation.
Reviewed-by: Dylan Baker <[email protected]>
Reviewed-by: Ian Romanick <[email protected]>
Diffstat (limited to 'docs/submittingpatches.html')
| -rw-r--r-- | docs/submittingpatches.html | 8 |
1 files changed, 8 insertions, 0 deletions
diff --git a/docs/submittingpatches.html b/docs/submittingpatches.html index d0b61a34099..61c6d1f8806 100644 --- a/docs/submittingpatches.html +++ b/docs/submittingpatches.html @@ -302,6 +302,14 @@ These Reviewed-by, Acked-by, and Tested-by tags should also be amended into commits in a MR before it is merged. </p> +<p> +Review by non-experts is encouraged. Understanding how someone else +goes about solving a problem is a great way to learn your way around +the project. The submitter is expected to evaluate whether they have +an appropriate amount of review feedback from people who also +understand the code before merging their patches. +</p> + <h2 id="nominations">Nominating a commit for a stable branch</h2> <p> |