diff options
author | Kenneth Graunke <[email protected]> | 2018-06-08 14:24:16 -0700 |
---|---|---|
committer | Kenneth Graunke <[email protected]> | 2018-06-14 14:58:59 -0700 |
commit | f6898f2b554e88255909bdd6bd0f7a91d99c446b (patch) | |
tree | cbead1bd0a96a88aeee807b09e7f2b90ea2eef51 /docs/mangling.html | |
parent | 37bd9ccd21b860d2b5ffea7e1f472ec83b68b43b (diff) |
intel/compiler: Properly consider UBO loads that cross 32B boundaries.
The UBO push analysis pass incorrectly assumed that all values would fit
within a 32B chunk, and only recorded a bit for the 32B chunk containing
the starting offset.
For example, if a UBO contained the following, tightly packed:
vec4 a; // [0, 16)
float b; // [16, 20)
vec4 c; // [20, 36)
then, c would start at offset 20 / 32 = 0 and end at 36 / 32 = 1,
which means that we ought to record two 32B chunks in the bitfield.
Similarly, dvec4s would suffer from the same problem.
v2: Rewrite the accounting, my calculations were wrong.
v3: Write a comment about partial values (requested by Jason).
Reviewed-by: Rafael Antognolli <[email protected]> [v1]
Reviewed-by: Jason Ekstrand <[email protected]> [v3]
Diffstat (limited to 'docs/mangling.html')
0 files changed, 0 insertions, 0 deletions