summaryrefslogtreecommitdiffstats
path: root/docs/devinfo.html
diff options
context:
space:
mode:
authorBrian Paul <[email protected]>2015-05-26 11:30:22 -0600
committerBrian Paul <[email protected]>2015-05-26 12:16:36 -0600
commit2ab0ca36c155cc77e3d5c950270c70a24efee3d3 (patch)
tree9540cacc9ffafd6aba842e37decb82592826211e /docs/devinfo.html
parentc6184f84b7227e1548947e42bca3ff3ddb7e379c (diff)
docs: add information about reviewing patches
Reviewed-by: Matt Turner <[email protected]>
Diffstat (limited to 'docs/devinfo.html')
-rw-r--r--docs/devinfo.html25
1 files changed, 25 insertions, 0 deletions
diff --git a/docs/devinfo.html b/docs/devinfo.html
index f5113b0bd72..eb3aba1364a 100644
--- a/docs/devinfo.html
+++ b/docs/devinfo.html
@@ -266,6 +266,31 @@ re-sending the whole series). Using --in-reply-to makes
it harder for reviewers to accidentally review old patches.
</p>
+<h3>Reviewing Patches</h3>
+
+<p>
+When you've reviewed a patch on the mailing list, please be unambiguous
+about your review. That is, state either
+<pre>
+ Reviewed-by: Joe Hacker &lt;[email protected]&gt;
+</pre>
+or
+<pre>
+ Acked-by: Joe Hacker &lt;[email protected]&gt;
+</pre>
+Rather than saying just "LGTM" or "Seems OK".
+</p>
+
+<p>
+If small changes are suggested, it's OK to say something like:
+<pre>
+ With the above fixes, Reviewed-by: Joe Hacker &lt;[email protected]&gt;
+</pre>
+which tells the patch author that the patch can be committed, as long
+as the issues are resolved first.
+</p>
+
+
<h3>Marking a commit as a candidate for a stable branch</h3>
<p>