diff options
author | Kenneth Graunke <[email protected]> | 2012-03-13 12:51:15 -0700 |
---|---|---|
committer | Kenneth Graunke <[email protected]> | 2012-03-26 10:21:53 -0700 |
commit | 2cd652f810e3417ff458f23a8c72a0c84e342258 (patch) | |
tree | 3bc450cd2628404766834692400da4b5d89db322 /docs/MESA_release_buffers.spec | |
parent | 25b0d45d038774406f2bb7173abc33a3cb261db2 (diff) |
glsl: Make ir_dereference_record constructor assert the variable exists.
Providing a NULL pointer to the ir_dereference_record() constructor
seems like a bad idea. Currently, if provided NULL, it returns a
partially constructed value of error type. However, none of the callers
are prepared to handle that scenario.
Code inspection shows that all callers do one of the following:
- Already NULL-check the argument prior to creating the dereference
- Already deference the argument (and thus would crash if it were NULL)
- Newly allocate the argument.
Thus, it should be safe to simply assert the value passed is not NULL.
This should also catch issues right away, rather than dying later.
Signed-off-by: Kenneth Graunke <[email protected]>
Reviewed-by: Eric Anholt <[email protected]>
Diffstat (limited to 'docs/MESA_release_buffers.spec')
0 files changed, 0 insertions, 0 deletions