summaryrefslogtreecommitdiffstats
path: root/configs/sunos5-v9-cc-g++
diff options
context:
space:
mode:
authorKenneth Graunke <[email protected]>2012-02-08 05:08:21 -0800
committerKenneth Graunke <[email protected]>2012-02-17 14:56:24 -0800
commitf9be8543aab9005c30b38331b9f7250a01720942 (patch)
tree22fcf87349ee5ca1db1a83441b4826e369717bf4 /configs/sunos5-v9-cc-g++
parente2dce7f7ee3e7da9cbb0bb33307ecd79e824426d (diff)
vbo: Remove pedantic warning about 'end' beind out of bounds.
The application supplied [start, end] range is merely a conservative hint of the ranges of index values inside the index buffer. There is no requirement that all vertices in the range [start, end] be referenced. Passing an 'end' value larger than the maximum legal index is perfectly acceptible; applications can legally pass 0xffffffff when they don't have a tighter bound readily available. Thus, the warning doesn't indicate a correctness issue; it could only indicate a performance issue. However, it does not even do that. glDrawRangeElements is designed to optimize non-VBO vertex data uploads by providing an upper bound on the size of buffers a driver would need to allocate. With VBOs, the data is already in an uploaded buffer, so the range doesn't help. The clincher is: we only know _MaxElement for VBOs. For user-space arrays, we just set it to 2,000,000,000 (see mesa/main/varray.h:63.) So we can only check this in the case where it is not useful. Many applications, including the Unigine demos, currently trigger this warning, which suggests the applications are buggy when they're actually fine. Eliminating the warning should confuse users less while not actually losing any benefit to application developers. NOTE: This is a candidate for release branches. Suggested-by: Jose Fonseca <[email protected]> Signed-off-by: Kenneth Graunke <[email protected]> Reviewed-by: Brian Paul <[email protected]> Reviewed-by: Roland Scheidegger <[email protected]>
Diffstat (limited to 'configs/sunos5-v9-cc-g++')
0 files changed, 0 insertions, 0 deletions