summaryrefslogtreecommitdiffstats
path: root/common.py
diff options
context:
space:
mode:
authorNeil Roberts <[email protected]>2018-04-24 12:17:56 +0200
committerNeil Roberts <[email protected]>2018-04-26 10:08:14 +0200
commitc4ab1bdcc9710e3c7cc7115d3be9c69b7e7712ef (patch)
tree103b26d7fdf4dda4643d7865aac71ddf42002fba /common.py
parent3ba5a646e58078f8d62d1d5f435a4939b98c8166 (diff)
spirv: Don’t check for NaN for most OpFOrd* comparisons
For all of the OpFOrd* comparisons except OpFOrdNotEqual the hardware should probably already return false if one of the operands is NaN so we don’t need to have an explicit check for it. This seems to at least work on Intel hardware. This should reduce the number of instructions generated for the most common comparisons. For what it’s worth, the original code to handle this was added in e062eb6415de3a. The commit message for that says that it was to fix some CTS tests for OpFUnord* opcodes. Even if the hardware doesn’t handle NaNs this patch shouldn’t affect those tests. At any rate they have since been moved out of the mustpass list. Incidentally those tests fail on the nvidia proprietary driver so it doesn’t seem like handling NaNs correctly is a priority. Reviewed-by: Iago Toral Quiroga <[email protected]> Reviewed-by: Bas Nieuwenhuizen <[email protected]>
Diffstat (limited to 'common.py')
0 files changed, 0 insertions, 0 deletions