summaryrefslogtreecommitdiffstats
path: root/REVIEWERS
diff options
context:
space:
mode:
authorJason Ekstrand <[email protected]>2017-06-29 10:33:30 -0700
committerJason Ekstrand <[email protected]>2017-07-05 15:26:53 -0700
commit6d30f33307cd95e2ee16de10b80a0d9881f788fd (patch)
treef37a9dec1996aef278f872cc5a4c35fb63a552ff /REVIEWERS
parent00c47e111ccda3d3b506140ebc7b46929a9d0b71 (diff)
nir/spirv: Simplify matrix loads/stores
Instead of handling all of the complexity at the end, we choose to decorate types a bit more cleverly. When we have a row-major matrix type, we give it the stride of a single vector and give it's array element type (which represents a column) the actual matrix stride. Previously, we were using stop_at_matrix and handling everything from matrix on down as special cases but now we walk the access chain all the way to the end and then load. Even though this looks like it may lead to a significant functional change, it doesn't. The reason why we needed to do stop_at_matrix before was to handle row-major properly since the offsets and strides would be all out-of-order. Now that row major matrix types have the small stride on the matrix and the large stride on the vector, offsetting to a single column of a row-major matrix works fine. The load/store code simply picks up on the fact that the stride isn't the type size and does multiple loads. The generated code from these methods should be the same. Reviewed-by: Connor Abbott <[email protected]>
Diffstat (limited to 'REVIEWERS')
0 files changed, 0 insertions, 0 deletions