summaryrefslogtreecommitdiffstats
path: root/REVIEWERS
diff options
context:
space:
mode:
authorNicolai Hähnle <[email protected]>2017-05-04 15:20:48 +0200
committerNicolai Hähnle <[email protected]>2017-05-08 17:42:16 +0200
commit854ed47f3e1501e4cc87bf9f19c6d4a1ad2bab08 (patch)
treeb7c0e566557069595d63d5658b4e8f2043a1df3d /REVIEWERS
parentf12fcb1c9dec9db5f158cc2bdaab273412006bf5 (diff)
radeonsi: mark fast-cleared textures as compressed when dirtying
There are a bunch of piglit fast clear tests that regressed on SI, for example ./bin/ext_framebuffer_multisample-fast-clear single-sample. The problem is that a texture is bound as a framebuffer, cleared, and then rendered from in a loop that loops through different clear colors. The texture is never rebound during all this, so the change to tex->dirty_level_mask during fast clear was not taken into account when checking for compressed textures. I have considered simply reverting the problematic commit. However, I think this solution is better. It does require looping through all bound textures after a fast clear, but the alternative would require visiting more textures needless on every draw. Draws are much more common than clears. Note that the rendering feedback loop rules do not apply here, because the framebuffer binding is changed between the glClear and the draw that samples from the texture that was cleared. Fixes: bdd644976952 ("radeonsi: don't mark non-dirty textures with CMASK as compressed") Cc: 17.1 <[email protected]> Reviewed-by: Marek Olšák <[email protected]>
Diffstat (limited to 'REVIEWERS')
0 files changed, 0 insertions, 0 deletions