diff options
author | Kenneth Graunke <[email protected]> | 2012-03-13 12:39:32 -0700 |
---|---|---|
committer | Kenneth Graunke <[email protected]> | 2012-03-26 10:21:51 -0700 |
commit | 25b0d45d038774406f2bb7173abc33a3cb261db2 (patch) | |
tree | e5aaec71287d309ad559ec601986d719dd7e87f2 /Android.mk | |
parent | ced54dcf9b496dbe0bf254673ecee37014c1ee3b (diff) |
glsl: Make ir_dereference_array constructor assert the variable exists.
Providing a NULL pointer to the ir_dereference_array() constructor seems
like a bad idea. Currently, if provided NULL, it returns a partially
constructed value of error type. However, none of the callers are
prepared to handle that scenario.
Code inspection shows that all callers do one of the following:
- Already NULL-check the argument prior to creating the dereference
- Already deference the argument (and thus would crash if it were NULL)
- Newly allocate the argument.
Thus, it should be safe to simply assert the value passed is not NULL.
This should also catch issues right away, rather than dying later.
Signed-off-by: Kenneth Graunke <[email protected]>
Reviewed-by: Eric Anholt <[email protected]>
Diffstat (limited to 'Android.mk')
0 files changed, 0 insertions, 0 deletions