diff options
| author | Mark Janes <[email protected]> | 2018-12-06 16:35:42 -0800 |
|---|---|---|
| committer | Mark Janes <[email protected]> | 2019-03-14 12:56:19 -0700 |
| commit | eb1a869a5d19bfd8a0d4099afd58f180997e4663 (patch) | |
| tree | c323c57e9f17b0778dbd6ffdaba8a745d82ae09d | |
| parent | 162286eb7529d469f64b83e11ff896ac3549add6 (diff) | |
mesa: properly report the length of truncated log messages
_mesa_log_msg must provide the length of the string passed into the
KHR_debug api. When the string formatted by _mesa_gl_vdebugf exceeds
MAX_DEBUG_MESSAGE_LENGTH, the length is incorrectly set to the number
of characters that would have been written if enough space had been
available.
Fixes: 30256805784450b8bb9d4dabfb56226271ca9d24
("mesa: Add support for GL_ARB_debug_output with dynamic ID allocation.")
Reviewed-by: Erik Faye-Lund <[email protected]>
| -rw-r--r-- | src/mesa/main/errors.c | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/src/mesa/main/errors.c b/src/mesa/main/errors.c index a9687913627..30560ba047e 100644 --- a/src/mesa/main/errors.c +++ b/src/mesa/main/errors.c @@ -231,6 +231,9 @@ _mesa_gl_vdebug(struct gl_context *ctx, _mesa_debug_get_id(id); len = _mesa_vsnprintf(s, MAX_DEBUG_MESSAGE_LENGTH, fmtString, args); + if (len >= MAX_DEBUG_MESSAGE_LENGTH) + /* message was truncated */ + len = MAX_DEBUG_MESSAGE_LENGTH - 1; _mesa_log_msg(ctx, source, type, *id, severity, len, s); } |