diff options
| author | Brian <[email protected]> | 2008-03-21 10:03:23 -0600 |
|---|---|---|
| committer | Brian <[email protected]> | 2008-03-21 11:10:42 -0600 |
| commit | b70a6babfbc035d64dbe35ac4bf9218e8232b435 (patch) | |
| tree | dc81a1fb2c132bafc126ad1adcd3200000516648 | |
| parent | 74525d474c4629b05dd588d13324f22a8a85fb70 (diff) | |
i915: added to-do note about setting the max_lod register to get proper min/mag filter selection
| -rw-r--r-- | src/gallium/drivers/i915simple/i915_state_sampler.c | 6 |
1 files changed, 6 insertions, 0 deletions
diff --git a/src/gallium/drivers/i915simple/i915_state_sampler.c b/src/gallium/drivers/i915simple/i915_state_sampler.c index 9dbb1b1b238..84f6529a3ad 100644 --- a/src/gallium/drivers/i915simple/i915_state_sampler.c +++ b/src/gallium/drivers/i915simple/i915_state_sampler.c @@ -206,6 +206,12 @@ i915_update_texture(struct i915_context *i915, uint unit, | format | MS3_USE_FENCE_REGS); + /* + * XXX sampler->max_lod should be used to program the MAX_LOD field below. + * Also, when min_filter != mag_filter and there's just one mipmap level, + * set max_lod = 1 to make sure i915 chooses between min/mag filtering. + */ + /* MS4 state */ state[1] = ((((pitch / 4) - 1) << MS4_PITCH_SHIFT) |