diff options
| author | Roland Scheidegger <[email protected]> | 2012-02-06 01:04:28 +0100 |
|---|---|---|
| committer | Roland Scheidegger <[email protected]> | 2012-02-06 01:04:28 +0100 |
| commit | 1f4a853b1e4691400ab832c589b044b659c20c06 (patch) | |
| tree | 0d515889011b4110db0f1b962c3cad706ca9fed2 | |
| parent | b3c84a80cd7f6d7d6796cb196422c7be44ea47aa (diff) | |
mesa: check_index_bounds off-by-one fix
in check_index_bounds the comparison needs to be "greater equal" since
contrary to the name _MaxElement is the count of the array (this matches
similar code in vbo_exec_DrawRangeElementsBaseVertex).
Reviewed-by: Kenneth Graunke <[email protected]>
| -rw-r--r-- | src/mesa/main/api_validate.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/mesa/main/api_validate.c b/src/mesa/main/api_validate.c index b6871d0dbd1..1ae491f25b5 100644 --- a/src/mesa/main/api_validate.c +++ b/src/mesa/main/api_validate.c @@ -187,7 +187,7 @@ check_index_bounds(struct gl_context *ctx, GLsizei count, GLenum type, vbo_get_minmax_indices(ctx, &prim, &ib, &min, &max, 1); if ((int)(min + basevertex) < 0 || - max + basevertex > ctx->Array.ArrayObj->_MaxElement) { + max + basevertex >= ctx->Array.ArrayObj->_MaxElement) { /* the max element is out of bounds of one or more enabled arrays */ _mesa_warning(ctx, "glDrawElements() index=%u is out of bounds (max=%u)", max, ctx->Array.ArrayObj->_MaxElement); |