summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorCaio Marcelo de Oliveira Filho <[email protected]>2019-08-23 07:41:18 -0700
committerCaio Marcelo de Oliveira Filho <[email protected]>2019-08-23 13:25:27 -0700
commitf7d90c67c7d564c270afc8ddf66ea1279043e39f (patch)
tree19f28144c8b64c7d99bcf01c33abcd8fa0acc314
parenta410823b3ede9ff3bf7f56ffca295d1b3d04dbad (diff)
intel/compiler: Silence maybe-uninitialized warning in GCC 9.1.1
Compiler can't see that d is initialized. ../src/intel/compiler/brw_vec4_nir.cpp: In function ‘int brw::try_immediate_source(const nir_alu_instr*, brw::src_reg*, bool, const gen_device_info*)’: ../src/intel/compiler/brw_vec4_nir.cpp:984:12: warning: ‘d’ may be used uninitialized in this function [-Wmaybe-uninitialized] 984 | d = MAX2(-d, d); Assert that we expect at least one component -- hence d going to be set. That by itself is not enough, so also zero initialize the variable. Acked-by: Eric Engestrom <[email protected]> Reviewed-by: Jason Ekstrand <[email protected]>
-rw-r--r--src/intel/compiler/brw_vec4_nir.cpp4
1 files changed, 3 insertions, 1 deletions
diff --git a/src/intel/compiler/brw_vec4_nir.cpp b/src/intel/compiler/brw_vec4_nir.cpp
index 6301c951144..c357ee2271b 100644
--- a/src/intel/compiler/brw_vec4_nir.cpp
+++ b/src/intel/compiler/brw_vec4_nir.cpp
@@ -963,7 +963,7 @@ try_immediate_source(const nir_alu_instr *instr, src_reg *op,
case BRW_REGISTER_TYPE_D:
case BRW_REGISTER_TYPE_UD: {
int first_comp = -1;
- int d;
+ int d = 0;
for (unsigned i = 0; i < NIR_MAX_VEC_COMPONENTS; i++) {
if (nir_alu_instr_channel_used(instr, idx, i)) {
@@ -978,6 +978,8 @@ try_immediate_source(const nir_alu_instr *instr, src_reg *op,
}
}
+ assert(first_comp >= 0);
+
if (op[idx].abs)
d = MAX2(-d, d);