diff options
| author | Marek Olšák <[email protected]> | 2019-12-23 19:42:46 -0500 |
|---|---|---|
| committer | Marek Olšák <[email protected]> | 2020-01-20 16:16:11 -0500 |
| commit | b2326a7549b237669d4aeb8a733eb13d15467093 (patch) | |
| tree | 293b23c53df1720692c2db9e309df35bad162e3f | |
| parent | 0f45d4dc2b15e137346e1e3f064a24302e1c9048 (diff) | |
radeonsi/gfx10: update comments and remove invalid TODOs
Acked-by: Pierre-Eric Pelloux-Prayer <[email protected]>
| -rw-r--r-- | src/gallium/drivers/radeonsi/gfx10_shader_ngg.c | 13 |
1 files changed, 1 insertions, 12 deletions
diff --git a/src/gallium/drivers/radeonsi/gfx10_shader_ngg.c b/src/gallium/drivers/radeonsi/gfx10_shader_ngg.c index afb9ad3f6ee..4d19f714e6c 100644 --- a/src/gallium/drivers/radeonsi/gfx10_shader_ngg.c +++ b/src/gallium/drivers/radeonsi/gfx10_shader_ngg.c @@ -640,7 +640,6 @@ void gfx10_emit_ngg_epilogue(struct ac_shader_abi *abi, ngg_get_vtx_cnt(ctx), ngg_get_prim_cnt(ctx)); /* Update query buffer */ - /* TODO: this won't catch 96-bit clear_buffer via transform feedback. */ if (ctx->screen->use_ngg_streamout && !info->properties[TGSI_PROPERTY_VS_BLIT_SGPRS_AMD]) { tmp = si_unpack_param(ctx, ctx->vs_state_bits, 6, 1); @@ -675,15 +674,7 @@ void gfx10_emit_ngg_epilogue(struct ac_shader_abi *abi, ac_build_endif(&ctx->ac, 5029); } - /* Build the primitive export. - * - * For the first version, we will always build up all three indices - * independent of the primitive type. The additional garbage data - * shouldn't hurt. - * - * TODO: culling depends on the primitive type, so can have some - * interaction here. - */ + /* Build the primitive export. */ ac_build_ifcc(&ctx->ac, is_gs_thread, 6001); { struct ac_ngg_prim prim = {}; @@ -1093,8 +1084,6 @@ void gfx10_ngg_gs_emit_epilogue(struct si_shader_context *ctx) ac_build_endif(&ctx->ac, 5109); } - /* TODO: culling */ - /* Determine vertex liveness. */ LLVMValueRef vertliveptr = ac_build_alloca(&ctx->ac, ctx->ac.i1, "vertexlive"); |