diff options
| author | Lionel Landwerlin <[email protected]> | 2019-09-20 01:24:53 +0300 |
|---|---|---|
| committer | Lionel Landwerlin <[email protected]> | 2019-11-11 21:46:51 +0000 |
| commit | 935f8f0e56a409b10fac86e18f68be776cdff29f (patch) | |
| tree | 94bf89a13ef23bb67f62a850b8507e0f223642c2 | |
| parent | 048f0690ee4b39f865d4d6ad82a6c0290dcaaf41 (diff) | |
anv: remove list items on batch fini
This doesn't seem to fix anything because those destroy() calls happen
right before the command buffer object & its list of batch_bo is also
destroyed. Still looks a bit cleaner.
v2: Found a second occurence
Signed-off-by: Lionel Landwerlin <[email protected]>
Reviewed-by: Jason Ekstrand <[email protected]> (v2)
Fixes: 26ba0ad54d ("vk: Re-name command buffer implementation files")
Cc: <[email protected]>
| -rw-r--r-- | src/intel/vulkan/anv_batch_chain.c | 5 |
1 files changed, 4 insertions, 1 deletions
diff --git a/src/intel/vulkan/anv_batch_chain.c b/src/intel/vulkan/anv_batch_chain.c index b1deae8e51c..f8e7a80b30f 100644 --- a/src/intel/vulkan/anv_batch_chain.c +++ b/src/intel/vulkan/anv_batch_chain.c @@ -517,8 +517,10 @@ anv_batch_bo_list_clone(const struct list_head *list, } if (result != VK_SUCCESS) { - list_for_each_entry_safe(struct anv_batch_bo, bbo, new_list, link) + list_for_each_entry_safe(struct anv_batch_bo, bbo, new_list, link) { + list_del(&bbo->link); anv_batch_bo_destroy(bbo, cmd_buffer); + } } return result; @@ -843,6 +845,7 @@ anv_cmd_buffer_fini_batch_bo_chain(struct anv_cmd_buffer *cmd_buffer) /* Destroy all of the batch buffers */ list_for_each_entry_safe(struct anv_batch_bo, bbo, &cmd_buffer->batch_bos, link) { + list_del(&bbo->link); anv_batch_bo_destroy(bbo, cmd_buffer); } } |