diff options
author | Brian Paul <[email protected]> | 2012-01-09 08:11:33 -0700 |
---|---|---|
committer | Brian Paul <[email protected]> | 2012-01-09 08:11:33 -0700 |
commit | 84c38c739e9faae86509eeec2bab4710813f9cc2 (patch) | |
tree | 6bc53c4e8510cb34332c9a0532add66b44f9e0c5 | |
parent | edca96547a2063c38d65a96e80fe6ad7144b5796 (diff) |
mesa: add missing error check for linear blit of integer colors
Reviewed-by: Kenneth Graunke <[email protected]>
-rw-r--r-- | src/mesa/main/fbobject.c | 13 |
1 files changed, 13 insertions, 0 deletions
diff --git a/src/mesa/main/fbobject.c b/src/mesa/main/fbobject.c index 912170aba47..1d5e3da3064 100644 --- a/src/mesa/main/fbobject.c +++ b/src/mesa/main/fbobject.c @@ -2742,6 +2742,19 @@ _mesa_BlitFramebufferEXT(GLint srcX0, GLint srcY0, GLint srcX1, GLint srcY1, } } + if (filter == GL_LINEAR && (mask & GL_COLOR_BUFFER_BIT)) { + /* 3.1 spec, page 199: + * "Calling BlitFramebuffer will result in an INVALID_OPERATION error + * if filter is LINEAR and read buffer contains integer data." + */ + GLenum type = _mesa_get_format_datatype(colorReadRb->Format); + if (type == GL_INT || type == GL_UNSIGNED_INT) { + _mesa_error(ctx, GL_INVALID_OPERATION, + "glBlitFramebufferEXT(integer color type)"); + return; + } + } + if (!ctx->Extensions.EXT_framebuffer_blit) { _mesa_error(ctx, GL_INVALID_OPERATION, "glBlitFramebufferEXT"); return; |