summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorIan Romanick <[email protected]>2019-12-05 08:25:34 -0800
committerMarge Bot <[email protected]>2020-01-23 00:18:57 +0000
commit74cd0964d684d7b91207b442eb3237fee1e4b4e0 (patch)
treee79dc61dd32513da42b15c685764d8939f1a0810
parentdb649fd5822569e1f33b058c0f4d38c27a47b083 (diff)
intel/fs: Don't lower integer multiplies that don't need lowering
v2: Move the check to fs_visitor::lower_integer_multiplication. Previously the cases where lowering was skipped, the original instruction was removed by fs_visitor::lower_integer_multiplication. Reviewed-by: Caio Marcelo de Oliveira Filho <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/767>
-rw-r--r--src/intel/compiler/brw_fs.cpp11
1 files changed, 11 insertions, 0 deletions
diff --git a/src/intel/compiler/brw_fs.cpp b/src/intel/compiler/brw_fs.cpp
index d9afe425e31..b09203cc87b 100644
--- a/src/intel/compiler/brw_fs.cpp
+++ b/src/intel/compiler/brw_fs.cpp
@@ -4107,6 +4107,17 @@ fs_visitor::lower_integer_multiplication()
foreach_block_and_inst_safe(block, fs_inst, inst, cfg) {
if (inst->opcode == BRW_OPCODE_MUL) {
+ /* If the instruction is already in a form that does not need lowering,
+ * return early.
+ */
+ if (devinfo->gen >= 7) {
+ if (type_sz(inst->src[1].type) < 4 && type_sz(inst->src[0].type) <= 4)
+ continue;
+ } else {
+ if (type_sz(inst->src[0].type) < 4 && type_sz(inst->src[1].type) <= 4)
+ continue;
+ }
+
if ((inst->dst.type == BRW_REGISTER_TYPE_Q ||
inst->dst.type == BRW_REGISTER_TYPE_UQ) &&
(inst->src[0].type == BRW_REGISTER_TYPE_Q ||