diff options
author | Vasily Khoruzhick <[email protected]> | 2019-09-28 09:57:55 -0700 |
---|---|---|
committer | Vasily Khoruzhick <[email protected]> | 2019-09-28 10:34:19 -0700 |
commit | 336b021d36f2eb84284a41aeb137bfaf243a0bc5 (patch) | |
tree | 76eb955c94a4eb91286290dd32a3a2bc86ea78ad | |
parent | 3f92d17894bedf2da6aabe017004391b91a5e860 (diff) |
lima: set uniforms_address lower bits properly
Looks like blob uses following values for uniforms buffer:
0 for 8 bytes
1 for 16 bytes
2 for 24 bytes
2 for 32 bytes
3 for 40 bytes
3 for 48 bytes
3 for 56 bytes
3 for 64 bytes
4 for 72 bytes
It all looks like log2(size / 8) rounded up, so let's do the same.
Fixes: 931fc2a7b3f9("lima: do not set the PP uniforms address lowest bits")
Reviewed-by: Icenowy Zheng <[email protected]>
Signed-off-by: Vasily Khoruzhick <[email protected]>
-rw-r--r-- | src/gallium/drivers/lima/lima_draw.c | 8 |
1 files changed, 8 insertions, 0 deletions
diff --git a/src/gallium/drivers/lima/lima_draw.c b/src/gallium/drivers/lima/lima_draw.c index 0449eaba7cd..bd6b62a3bb6 100644 --- a/src/gallium/drivers/lima/lima_draw.c +++ b/src/gallium/drivers/lima/lima_draw.c @@ -1086,6 +1086,14 @@ lima_pack_render_state(struct lima_context *ctx, const struct pipe_draw_info *in if (ctx->const_buffer[PIPE_SHADER_FRAGMENT].buffer) { render->uniforms_address = lima_ctx_buff_va(ctx, lima_ctx_buff_pp_uniform_array, LIMA_CTX_BUFF_SUBMIT_PP); + uint32_t size = ctx->buffer_state[lima_ctx_buff_pp_uniform].size; + uint32_t bits = 0; + if (size >= 8) { + bits = util_last_bit(size >> 3) - 1; + bits += size & u_bit_consecutive(0, bits + 3) ? 1 : 0; + } + render->uniforms_address |= bits > 0xf ? 0xf : bits; + render->aux0 |= 0x80; render->aux1 |= 0x10000; } |