summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorIan Romanick <[email protected]>2018-07-02 20:29:27 -0700
committerIan Romanick <[email protected]>2018-07-05 21:13:32 -0700
commit965a06dbd7401fb319b6f85ca55c9687a05335f1 (patch)
treedd534c1a180d60cb68647b46c52b77266dcf63a4
parenta4d478732712799d47f32cdbd2a7dca01239dc70 (diff)
i965/vec4: Make the vec4_visitor::nir_emit_instr default case unreachable
The bug fixed by the previous commit went undetected because extra stderr messages are not flagged by the CI. Copy the solution from fs_visitor::nir_emit_instr and mark the default case unreachable. An alternate solution is to delete the default case so that the compiler will issue a warning. That may require more work since there are other (impossible) cases that exist. Signed-off-by: Ian Romanick <[email protected]> Reviewed-by: Jason Ekstrand <[email protected]>
-rw-r--r--src/intel/compiler/brw_vec4_nir.cpp3
1 files changed, 1 insertions, 2 deletions
diff --git a/src/intel/compiler/brw_vec4_nir.cpp b/src/intel/compiler/brw_vec4_nir.cpp
index 7131fa06b4a..b77fa5fa821 100644
--- a/src/intel/compiler/brw_vec4_nir.cpp
+++ b/src/intel/compiler/brw_vec4_nir.cpp
@@ -169,8 +169,7 @@ vec4_visitor::nir_emit_instr(nir_instr *instr)
break;
default:
- fprintf(stderr, "VS instruction not yet implemented by NIR->vec4\n");
- break;
+ unreachable("VS instruction not yet implemented by NIR->vec4");
}
}