diff options
| author | Neil Roberts <[email protected]> | 2018-12-02 18:15:52 +0100 |
|---|---|---|
| committer | Rob Clark <[email protected]> | 2019-06-03 12:44:03 -0700 |
| commit | 8cd1b76b7d9e5190b74653c4f40672c2024839a1 (patch) | |
| tree | bb5203bdd789eab98b7f5575f4bba04495afc42f | |
| parent | 7bbf21e89830588c576264c74e94076ea94eab34 (diff) | |
freedreno/ir3: Fix loading half-float immediate vectors
Previously the code to load from a constant instruction was always
using the u32 pointer. If the constant is actually a 16-bit source
this would end up with the wrong values because the pointer would be
offset by the wrong size. This fixes it to use the u16 pointer.
Signed-off-by: Rob Clark <[email protected]>
| -rw-r--r-- | src/freedreno/ir3/ir3_compiler_nir.c | 15 |
1 files changed, 12 insertions, 3 deletions
diff --git a/src/freedreno/ir3/ir3_compiler_nir.c b/src/freedreno/ir3/ir3_compiler_nir.c index f4192b961d7..0a97c42159f 100644 --- a/src/freedreno/ir3/ir3_compiler_nir.c +++ b/src/freedreno/ir3/ir3_compiler_nir.c @@ -1586,10 +1586,19 @@ emit_load_const(struct ir3_context *ctx, nir_load_const_instr *instr) { struct ir3_instruction **dst = ir3_get_dst_ssa(ctx, &instr->def, instr->def.num_components); - type_t type = (instr->def.bit_size < 32) ? TYPE_U16 : TYPE_U32; - for (int i = 0; i < instr->def.num_components; i++) - dst[i] = create_immed_typed(ctx->block, instr->value[i].u32, type); + if (instr->def.bit_size < 32) { + for (int i = 0; i < instr->def.num_components; i++) + dst[i] = create_immed_typed(ctx->block, + instr->value[i].u16, + TYPE_U16); + } else { + for (int i = 0; i < instr->def.num_components; i++) + dst[i] = create_immed_typed(ctx->block, + instr->value[i].u32, + TYPE_U32); + } + } static void |