summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorKenneth Graunke <[email protected]>2018-12-22 23:09:16 -0800
committerKenneth Graunke <[email protected]>2019-02-21 10:26:11 -0800
commit5be72d9a20bf29e6f908594e2fa3214a24cc6271 (patch)
tree60aa46c716059a4161bac0cb6794cd1467e29f98
parent73709be0c32601952b6902d83ec4541fb9f73cd9 (diff)
iris: Delete bogus comment about cube array counting.
Both 'z' and 'depth' are counted in slices, according to the Gallium docs (context.rst). In our temporary memory, we allocate `box.depth` slices, so we need to rebase the starting slice (box.z) down to 0, and back again when writing on unmap. There's nothing strange about cubes here.
-rw-r--r--src/gallium/drivers/iris/iris_resource.c6
1 files changed, 1 insertions, 5 deletions
diff --git a/src/gallium/drivers/iris/iris_resource.c b/src/gallium/drivers/iris/iris_resource.c
index 1117ebec15d..0751b19267c 100644
--- a/src/gallium/drivers/iris/iris_resource.c
+++ b/src/gallium/drivers/iris/iris_resource.c
@@ -769,11 +769,7 @@ iris_map_tiled_memcpy(struct iris_transfer *map)
unsigned x1, x2, y1, y2;
tile_extents(surf, &box, xfer->level, &x1, &x2, &y1, &y2);
- /* When transferring cubes, box.depth is counted in cubes, but
- * box.z is counted in faces. We want to transfer only the
- * specified face, but for all array elements. So, use 's'
- * (the zero-based slice count) rather than box.z.
- */
+ /* Use 's' rather than 'box.z' to rebase the first slice to 0. */
void *ptr = map->ptr + s * xfer->layer_stride;
isl_memcpy_tiled_to_linear(x1, x2, y1, y2, ptr, src, xfer->stride,