summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorKenneth Graunke <[email protected]>2018-01-05 12:07:20 -0800
committerKenneth Graunke <[email protected]>2018-01-06 20:10:32 -0800
commit1c9f1a28c0738a0b1cb8626af431d18eeee3f4f1 (patch)
tree84a7c70a89f45f14b96f2cdd8d85624c6e8af601
parenta693a6f51aa7c7e5db02e2a13d676c56b2aaed86 (diff)
i965: Require space for MI_BATCHBUFFER_END.
intel_batchbuffer_emit_dword doesn't reserve space for the DWord it emits. In the past, we had some reserved batch space to ensure this worked. With the switch to growing batches, we need to actually request space so that we grow if necessary. Fixes: 2c46a67b4138631217141f (i965: Delete BATCH_RESERVED handling.) Cc: [email protected] Reviewed-by: Jason Ekstrand <[email protected]>
-rw-r--r--src/mesa/drivers/dri/i965/intel_batchbuffer.c7
1 files changed, 5 insertions, 2 deletions
diff --git a/src/mesa/drivers/dri/i965/intel_batchbuffer.c b/src/mesa/drivers/dri/i965/intel_batchbuffer.c
index 0e090f46250..3fd8e05d3dc 100644
--- a/src/mesa/drivers/dri/i965/intel_batchbuffer.c
+++ b/src/mesa/drivers/dri/i965/intel_batchbuffer.c
@@ -687,10 +687,13 @@ brw_finish_batch(struct brw_context *brw)
}
}
- /* Mark the end of the buffer. */
+ /* Emit MI_BATCH_BUFFER_END to finish our batch. Note that execbuf2
+ * requires our batch size to be QWord aligned, so we pad it out if
+ * necessary by emitting an extra MI_NOOP after the end.
+ */
+ intel_batchbuffer_require_space(brw, 8, brw->batch.ring);
intel_batchbuffer_emit_dword(&brw->batch, MI_BATCH_BUFFER_END);
if (USED_BATCH(brw->batch) & 1) {
- /* Round batchbuffer usage to 2 DWORDs. */
intel_batchbuffer_emit_dword(&brw->batch, MI_NOOP);
}