diff options
| author | Ian Romanick <[email protected]> | 2019-08-12 12:08:40 -0700 |
|---|---|---|
| committer | Ian Romanick <[email protected]> | 2019-08-29 13:15:53 -0700 |
| commit | 0b4782fccd22b0a01ded1e4cbfe06821bdf19d05 (patch) | |
| tree | afee6aa8ac271bacc334894968cc44c8c4806660 | |
| parent | ef2e235252ea3dbadad79bb48c760bb6c376b97c (diff) | |
nir/range-analysis: Fix incorrect fadd range result for (ne_zero, ne_zero)
Found by inspection. I tried really, really hard to make a test case
that would trigger this problem, but I was unsuccesful. It's very hard
to get an instruction to produce a ne_zero result without ne_zero
sources. The most plausible way is using bcsel. That proves
problematic because bcsel interprets its sources as integers, so it
cannot currently be used to "clean" values for floating point
instructions.
No shader-db changes on any Intel platform.
Reviewed-by: Caio Marcelo de Oliveira Filho <[email protected]>
Fixes: 405de7ccb6c ("nir/range-analysis: Rudimentary value range analysis pass")
| -rw-r--r-- | src/compiler/nir/nir_range_analysis.c | 11 |
1 files changed, 8 insertions, 3 deletions
diff --git a/src/compiler/nir/nir_range_analysis.c b/src/compiler/nir/nir_range_analysis.c index 5b0c39e4922..b7a2f20d473 100644 --- a/src/compiler/nir/nir_range_analysis.c +++ b/src/compiler/nir/nir_range_analysis.c @@ -247,9 +247,15 @@ analyze_expression(const nir_alu_instr *instr, unsigned src, * | lt_zero + lt_zero * ; * + * ne_zero: eq_zero + ne_zero + * | ne_zero + eq_zero # Addition is commutative + * ; + * * eq_zero: eq_zero + eq_zero + * ; * - * All other cases are 'unknown'. + * All other cases are 'unknown'. The seeming odd entry is (ne_zero, + * ne_zero), but that could be (-5, +5) which is not ne_zero. */ static const enum ssa_ranges fadd_table[last_range + 1][last_range + 1] = { /* left\right unknown lt_zero le_zero gt_zero ge_zero ne_zero eq_zero */ @@ -258,12 +264,11 @@ analyze_expression(const nir_alu_instr *instr, unsigned src, /* le_zero */ { _______, lt_zero, le_zero, _______, _______, _______, le_zero }, /* gt_zero */ { _______, _______, _______, gt_zero, gt_zero, _______, gt_zero }, /* ge_zero */ { _______, _______, _______, gt_zero, ge_zero, _______, ge_zero }, - /* ne_zero */ { _______, _______, _______, _______, _______, ne_zero, ne_zero }, + /* ne_zero */ { _______, _______, _______, _______, _______, _______, ne_zero }, /* eq_zero */ { _______, lt_zero, le_zero, gt_zero, ge_zero, ne_zero, eq_zero }, }; ASSERT_TABLE_IS_COMMUTATIVE(fadd_table); - ASSERT_TABLE_IS_DIAGONAL(fadd_table); /* Due to flush-to-zero semanatics of floating-point numbers with very * small mangnitudes, we can never really be sure a result will be |