summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorEric Engestrom <[email protected]>2018-05-18 17:12:53 +0100
committerDylan Baker <[email protected]>2018-05-30 16:56:47 -0700
commitdf303adc29e580f3eb27e5e787387dfe98aaa56f (patch)
tree06f3f462a1e0c3520885b4bb914a1a9bf2a6958e
parentb6167e9640664b22d025813fb4061c91aae2af8c (diff)
vulkan: don't free uninitialised memory
The modifiers array hasn't been initialised by then, much less with data that would need freeing. Move the label after the loop to fix this. Fixes: c80c08e22603 ("vulkan/wsi/x11: Add support for DRI3 v1.2") Signed-off-by: Eric Engestrom <[email protected]> Reviewed-by: Lionel Landwerlin <[email protected]> (cherry picked from commit e4fe2fd3bb26d52e64d98207692a4469f04fe1d5)
-rw-r--r--src/vulkan/wsi/wsi_common_x11.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/src/vulkan/wsi/wsi_common_x11.c b/src/vulkan/wsi/wsi_common_x11.c
index 62739b99125..1bfbc7c3001 100644
--- a/src/vulkan/wsi/wsi_common_x11.c
+++ b/src/vulkan/wsi/wsi_common_x11.c
@@ -1421,10 +1421,10 @@ fail_init_images:
for (uint32_t j = 0; j < image; j++)
x11_image_finish(chain, pAllocator, &chain->images[j]);
-fail_register:
for (int i = 0; i < ARRAY_SIZE(modifiers); i++)
vk_free(pAllocator, modifiers[i]);
+fail_register:
xcb_unregister_for_special_event(chain->conn, chain->special_event);
wsi_swapchain_finish(&chain->base);