diff options
| author | Jose Fonseca <[email protected]> | 2017-06-01 16:41:13 +0100 |
|---|---|---|
| committer | Jose Fonseca <[email protected]> | 2017-06-01 21:24:38 +0100 |
| commit | ce5e83b8a0c757072075e781a090d35d9dc0e285 (patch) | |
| tree | ee9180dda2ff78a9ddad1706b3772d9e17d43fa1 | |
| parent | 9d996e94fbbfdb3692061009f5441cf61bba36ae (diff) | |
automake: Link all libGL.so variants with -Bsymbolic.
We were linking src/glx with -Bsymbolic, but not the classic/gallium X11
libGL.so.
But it's always a good idea to build all libGL.so and all DRI drivers
with -Bsymbolic, otherwise they might resolve symbols from the 3rd party
application executable or shared libraries, which is _never_ what we
want.
In particular, this can happen when intercepting OpenGL calls with
apitrace, before
https://github.com/apitrace/apitrace/commit/63194b2573176ef34efce1a5c8b08e624b8dddf5
Cc: [email protected]
Reviewed-by: Brian Paul <[email protected]>
Reviewed-by: Emil Velikov <[email protected]>
| -rw-r--r-- | src/gallium/targets/libgl-xlib/Makefile.am | 1 | ||||
| -rw-r--r-- | src/mesa/drivers/x11/Makefile.am | 1 |
2 files changed, 2 insertions, 0 deletions
diff --git a/src/gallium/targets/libgl-xlib/Makefile.am b/src/gallium/targets/libgl-xlib/Makefile.am index d3a781848e7..a29199fe784 100644 --- a/src/gallium/targets/libgl-xlib/Makefile.am +++ b/src/gallium/targets/libgl-xlib/Makefile.am @@ -52,6 +52,7 @@ lib@GL_LIB@_la_SOURCES = xlib.c lib@GL_LIB@_la_LDFLAGS = \ -no-undefined \ -version-number $(GL_MAJOR):$(GL_MINOR):$(GL_TINY) \ + $(BSYMBOLIC) \ $(GC_SECTIONS) \ $(LD_NO_UNDEFINED) diff --git a/src/mesa/drivers/x11/Makefile.am b/src/mesa/drivers/x11/Makefile.am index 8c6b67d6a8d..6e123ba1b35 100644 --- a/src/mesa/drivers/x11/Makefile.am +++ b/src/mesa/drivers/x11/Makefile.am @@ -74,6 +74,7 @@ lib@GL_LIB@_la_LIBADD = \ lib@GL_LIB@_la_LDFLAGS = \ -no-undefined \ -version-number $(GL_MAJOR):$(GL_MINOR):$(GL_PATCH) \ + $(BSYMBOLIC) \ $(GC_SECTIONS) \ $(LD_NO_UNDEFINED) |